From: David Hunter <david.hunter.linux@gmail.com>
To: vivek yadav <vivekyadav1207731111@gmail.com>,
Johan Hovold <johan@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] usb: serial: fix: space prohibited before comma separator
Date: Mon, 6 Oct 2025 21:03:03 -0400 [thread overview]
Message-ID: <03a4cb5e-85da-44f3-8fcc-67e23920cd5a@gmail.com> (raw)
In-Reply-To: <CABPSWR4W5Eyz8=NPvysT7XhFY=bjCO_WqqOOMWeZGen9e2fhqQ@mail.gmail.com>
On 10/6/25 13:54, vivek yadav wrote:
> Hi Johan,
> Thanks for giving time for the review of my patch.
> I understand your point and will avoid such kind of practice.
>
>
> ~~Vivek
>
> On Mon, Oct 6, 2025 at 5:42 PM Johan Hovold <johan@kernel.org> wrote:
>>
>> On Sat, Oct 04, 2025 at 12:26:18PM +0530, vivekyadav1207731111@gmail.com wrote:
>>> From: Vivek Yadav <vivekyadav1207731111@gmail.com>
>>>
>>> Run `checkpatch.pl` script on path `drivers/usb/serial/*`.
>>
>> Yeah, don't do that, that is, don't run checkpatch on code that's
>> already in the tree. Use it on your on patches before submitting them to
>> catch potential issues, but always use your own judgement when
>> considering its output.
>>
>> If you just want to practise sending patches, changes like these are
>> accepted for drivers/staging for that purpose.
>>
>> Johan
Please don't top-post. please look at the following wikipedia page to
see what top-post means:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
prev parent reply other threads:[~2025-10-07 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-04 6:56 [PATCH] usb: serial: fix: space prohibited before comma separator vivekyadav1207731111
2025-10-06 12:12 ` Johan Hovold
2025-10-06 17:54 ` vivek yadav
2025-10-07 1:03 ` David Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a4cb5e-85da-44f3-8fcc-67e23920cd5a@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vivekyadav1207731111@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox