From: Markus Elfring <Markus.Elfring@web.de>
To: Luis Felipe Hernandez <luis.hernandez093@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
Evgeniy Dushistov <dushistov@mail.ru>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/ufs: Use LUT for dir entry types
Date: Mon, 10 Jun 2024 09:48:09 +0200 [thread overview]
Message-ID: <0485dd2d-488a-40e9-b0f7-24236b9c00ab@web.de> (raw)
In-Reply-To: <20240610034219.14711-1-luis.hernandez093@gmail.com>
> As per the original TODO, replacing the switch statement with a lookup
> table results in more concise mapping logic and improved performance.
…
Can imperative wordings be relevant for another improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94
…
> +++ b/fs/ufs/util.h
…
> static inline void
> ufs_set_de_type(struct super_block *sb, struct ufs_dir_entry *de, int mode)
…
> + if (mode_index < ARRAY_SIZE(ufs_mode_to_dt))
> + de->d_u.d_44.d_type = ufs_mode_to_dt[mode_index];
> + else
> de->d_u.d_44.d_type = DT_UNKNOWN;
…
May a conditional operator expression be applied at this source code place?
Regards,
Markus
next prev parent reply other threads:[~2024-06-10 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 3:42 [PATCH] fs/ufs: Use LUT for dir entry types Luis Felipe Hernandez
2024-06-10 7:48 ` Markus Elfring [this message]
2024-06-10 8:00 ` Greg KH
2024-06-19 1:15 ` Luis Felipe Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0485dd2d-488a-40e9-b0f7-24236b9c00ab@web.de \
--to=markus.elfring@web.de \
--cc=dushistov@mail.ru \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luis.hernandez093@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox