From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Abhishek Tamboli <abhishektamboli9@gmail.com>,
gregkh@linuxfoundation.org
Cc: Frank.Li@nxp.com, m.grzeschik@pengutronix.de,
dan.scally@ideasonboard.com, andrzej.p@collabora.com,
quic_jjohnson@quicinc.com, shuzhenwang@google.com,
arakesh@google.com, skhan@linuxfoundation.org,
rbmarliere@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro
Date: Mon, 14 Oct 2024 10:43:25 +0100 [thread overview]
Message-ID: <172889900570.877857.1005868402461236136@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20241013142511.9946-1-abhishektamboli9@gmail.com>
Quoting Abhishek Tamboli (2024-10-13 15:25:11)
> Remove the extra semicolon after the
> do {} while (0) in UVC_COPY_DESCRIPTOR macro.
>
> Fix the following checkpatch.pl warning
>
> WARNING: do {} while (0) macros should not be semicolon terminated
> +#define UVC_COPY_DESCRIPTOR(mem, dst, desc) \
> + do { \
> + memcpy(mem, desc, (desc)->bLength); \
> + *(dst)++ = mem; \
> + mem += (desc)->bLength; \
> + } while (0);
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> drivers/usb/gadget/function/f_uvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/f_uvc.c b/drivers/usb/gadget/function/f_uvc.c
> index 40187b7112e7..edf0355d712c 100644
> --- a/drivers/usb/gadget/function/f_uvc.c
> +++ b/drivers/usb/gadget/function/f_uvc.c
> @@ -465,7 +465,7 @@ uvc_register_video(struct uvc_device *uvc)
> memcpy(mem, desc, (desc)->bLength); \
> *(dst)++ = mem; \
> mem += (desc)->bLength; \
> - } while (0);
> + } while (0)
>
> #define UVC_COPY_DESCRIPTORS(mem, dst, src) \
> do { \
> --
> 2.34.1
>
prev parent reply other threads:[~2024-10-14 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 14:25 [PATCH] usb: gadget: uvc: Remove extra semicolon from the macro Abhishek Tamboli
2024-10-14 9:43 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172889900570.877857.1005868402461236136@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=Frank.Li@nxp.com \
--cc=abhishektamboli9@gmail.com \
--cc=andrzej.p@collabora.com \
--cc=arakesh@google.com \
--cc=dan.scally@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=quic_jjohnson@quicinc.com \
--cc=rbmarliere@gmail.com \
--cc=shuzhenwang@google.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox