From: Stephen Boyd <sboyd@kernel.org>
To: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>, dlan@gentoo.org
Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org,
Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
Subject: Re: [PATCH v2] clk: spacemit: fix resource leak in spacemit_ccu_reset_register
Date: Thu, 24 Jul 2025 19:36:44 -0700 [thread overview]
Message-ID: <175341100482.3513.10826909212334043021@lazor> (raw)
In-Reply-To: <20250723132504.66273-1-hendrik.hamerlinck@hammernet.be>
Quoting Hendrik Hamerlinck (2025-07-23 06:25:04)
> The function spacemit_ccu_reset_register() allocates memory for an
> auxiliary device. If auxiliary_device_add() fails, it skips cleanup of
> these resources, resulting in leaks.
>
> Fix this by using the appropriate error handling path.
>
> Fixes: 988543522ebd ("clk: spacemit: set up reset auxiliary devices")
> Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
> Reviewed-by: Yixun Lan <dlan@gentoo.org>
> ---
Applied to clk-next
next prev parent reply other threads:[~2025-07-25 2:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 13:25 [PATCH v2] clk: spacemit: fix resource leak in spacemit_ccu_reset_register Hendrik Hamerlinck
2025-07-25 2:36 ` Stephen Boyd [this message]
2025-07-26 9:16 ` Christophe JAILLET
2025-07-26 12:10 ` Yixun Lan
2025-07-26 12:57 ` Alex Elder
2025-07-26 18:00 ` Hendrik Hamerlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175341100482.3513.10826909212334043021@lazor \
--to=sboyd@kernel.org \
--cc=dlan@gentoo.org \
--cc=hendrik.hamerlinck@hammernet.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox