From mboxrd@z Thu Jan 1 00:00:00 1970 From: stephen at networkplumber.org (Stephen Hemminger) Date: Thu, 20 Jun 2019 11:37:12 -0700 Subject: [Linux-kernel-mentees] [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates In-Reply-To: <20190620180754.15413-1-puranjay12@gmail.com> References: <20190620180754.15413-1-puranjay12@gmail.com> Message-ID: <20190620113712.4630f60f@hermes.lan> List-Id: On Thu, 20 Jun 2019 23:37:51 +0530 Puranjay Mohan wrote: > This patch series removes the private duplicates of PCI definitions in > favour of generic definitions defined in pci_regs.h. > > This driver only uses one of the generic PCI definitons, i.e. > PCI_REVISION_ID, which is included from pci_regs.h and its private > version is removed from skfbi.h with all other private defines. > > The skfbi.h defines PCI_REV_ID which is renamed to PCI_REVISION_ID in > drvfbi.c to make it compatible with the generic define in pci_regs.h. > > Puranjay Mohan (3): > net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID > net: fddi: skfp: Include generic PCI definitions > net: fddi: skfp: Remove unused private PCI definitions > > drivers/net/fddi/skfp/drvfbi.c | 4 +- > drivers/net/fddi/skfp/h/skfbi.h | 207 +------------------------------- > 2 files changed, 3 insertions(+), 208 deletions(-) > Does anyone still have the hardware to test this? Maybe FDDI should be put out to pasture. From mboxrd@z Thu Jan 1 00:00:00 1970 From: stephen@networkplumber.org (Stephen Hemminger) Date: Thu, 20 Jun 2019 11:37:12 -0700 Subject: [Linux-kernel-mentees] [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates In-Reply-To: <20190620180754.15413-1-puranjay12@gmail.com> References: <20190620180754.15413-1-puranjay12@gmail.com> Message-ID: <20190620113712.4630f60f@hermes.lan> List-Id: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190620183712.8hzhdAyDCz8ASd6goGQczINGEXM7PmaIQSCQRbaHxjM@z> On Thu, 20 Jun 2019 23:37:51 +0530 Puranjay Mohan wrote: > This patch series removes the private duplicates of PCI definitions in > favour of generic definitions defined in pci_regs.h. > > This driver only uses one of the generic PCI definitons, i.e. > PCI_REVISION_ID, which is included from pci_regs.h and its private > version is removed from skfbi.h with all other private defines. > > The skfbi.h defines PCI_REV_ID which is renamed to PCI_REVISION_ID in > drvfbi.c to make it compatible with the generic define in pci_regs.h. > > Puranjay Mohan (3): > net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID > net: fddi: skfp: Include generic PCI definitions > net: fddi: skfp: Remove unused private PCI definitions > > drivers/net/fddi/skfp/drvfbi.c | 4 +- > drivers/net/fddi/skfp/h/skfbi.h | 207 +------------------------------- > 2 files changed, 3 insertions(+), 208 deletions(-) > Does anyone still have the hardware to test this? Maybe FDDI should be put out to pasture.