From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF31C43331 for ; Tue, 31 Mar 2020 22:57:13 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3F8B20842 for ; Tue, 31 Mar 2020 22:57:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3F8B20842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lwn.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8FAE887E5E; Tue, 31 Mar 2020 22:57:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9DVdVztStfiS; Tue, 31 Mar 2020 22:57:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 2E45587E16; Tue, 31 Mar 2020 22:57:12 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 180ACC1AE2; Tue, 31 Mar 2020 22:57:12 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0D976C07FF for ; Tue, 31 Mar 2020 22:57:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 02A8E81B86 for ; Tue, 31 Mar 2020 22:57:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 49jXElwZtP9Y for ; Tue, 31 Mar 2020 22:57:09 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by hemlock.osuosl.org (Postfix) with ESMTPS id 9DBA188936 for ; Tue, 31 Mar 2020 22:57:09 +0000 (UTC) Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 16E572F3; Tue, 31 Mar 2020 22:57:09 +0000 (UTC) Date: Tue, 31 Mar 2020 16:57:07 -0600 From: Jonathan Corbet To: Vitor Massaru Iha Message-ID: <20200331165707.7c708646@lwn.net> In-Reply-To: <637c0379a76fcf4eb6cdde0de3cc727203fd942f.1585693146.git.vitor@massaru.org> References: <637c0379a76fcf4eb6cdde0de3cc727203fd942f.1585693146.git.vitor@massaru.org> Organization: LWN.net MIME-Version: 1.0 Cc: linux-kernel-mentees@lists.linuxfoundation.org, brendanhiggins@google.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH 1/2] Documentation: filesystems: Convert sysfs-pci to ReST X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Tue, 31 Mar 2020 19:28:56 -0300 Vitor Massaru Iha wrote: > Signed-off-by: Vitor Massaru Iha > --- > .../{sysfs-pci.txt => sysfs-pci.rst} | 40 ++++++++++--------- > 1 file changed, 22 insertions(+), 18 deletions(-) > rename Documentation/filesystems/{sysfs-pci.txt => sysfs-pci.rst} (82%) Please supply a changelog with your patches. The conversion you have done in this file is incomplete; I suspect that you have not actually built the docs and seen what the results look like. There are literal blocks that you have not marked as such, as a minimum. Please actually do a docs build (after adding this file to index.rst) and make sure that the output is what you intended. One other thing of note...this file dates back to before the Git era, and while it has seen numerous tweaks since then, it's clearly outdated. Look at what's actually under /sys/devices/pci* compared to what's documented. I will take the conversion without it, but what I would really like to see would be an effort to document all of the attributes that appear there with current kernels. Thanks, jon _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees