From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03922C433E0 for ; Mon, 15 Jun 2020 13:54:53 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBCBC207DA for ; Mon, 15 Jun 2020 13:54:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ed8Hh6W1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBCBC207DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 92AB3885A8; Mon, 15 Jun 2020 13:54:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oF+bETi2LSmR; Mon, 15 Jun 2020 13:54:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 8D71A88745; Mon, 15 Jun 2020 13:54:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7AF3DC0890; Mon, 15 Jun 2020 13:54:51 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 65F4DC016E for ; Mon, 15 Jun 2020 13:54:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4EDFA87F76 for ; Mon, 15 Jun 2020 13:54:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MwYbT1+AnEKh for ; Mon, 15 Jun 2020 13:54:48 +0000 (UTC) X-Greylist: delayed 00:07:55 by SQLgrey-1.7.6 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by whitealder.osuosl.org (Postfix) with ESMTPS id E723487929 for ; Mon, 15 Jun 2020 13:54:47 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id w1so15740385qkw.5 for ; Mon, 15 Jun 2020 06:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5fbwAPFhj/t9OUXsbkBLa2lLyWbmpKqf/KaN0uZtDRI=; b=ed8Hh6W19/qv58dB6PJ+JDjl39VwebBT6j8EE97r3JHHDfwiJzt2hWVj16rCe6/VyG TGS6SE6ptiPexO04eKRNwcc2SavSPpI4Y+CNvCCPSLOeqvoWAFB5eirFpEK6+oB0wHHn YzrrGXXq34tALTQcvCQ5jV7jNVPV1gaoA7dxV+Ww8bCsTfAxqZWkLH2X+TRnp6v1UY/n 5HvDJCpObIPTLoiUUvWm+Bh/6YdsUHOii7rZ0rTYrZCnagGu2eBunuySbs4KjAKcsich MHcryQhOUqxOkk25chIvq/NKjlr7ebKpn+uV5+YAUDcny6vx0EfBF5i2EahuqiwvnIGH ZLNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5fbwAPFhj/t9OUXsbkBLa2lLyWbmpKqf/KaN0uZtDRI=; b=aXF9IlTNhedDzYWrWvj45if5EGhT6/M7XunVbiLm3P8HIDhpgGqU4O0bhC29s9Gn/n Co+3+FdOt0bDyQlCI8ml1WLjl0BPMR88Vlloid9IDtQZ0ltpfOTDSwy6X0CfNt3vMOD5 A+a4a/EGG4hmjzpJ2QNwJKSPYBVU9IuyAMDiM4F9psFg24j/7ZH0vqlTtuxawxUcX/CR SD8OzEz8qOgvIpSMVHE/wCauog/kl1Z3/2t9GoXGw2VBnBgcIap+RbHnuhMlE5zG3Spk XcL3gog63F+ZaZp250aRnR4NLDl9QuHWuQXO8/Y0kBReAIEQnws6mDsmh4/lH5OpMhJQ zaUA== X-Gm-Message-State: AOAM533rhnvNrSFOD/PgiPKCPdMlww6uppjqvZZtAu5zOmYzxSSbH6H+ c1YLIvDPspHzJu0iZ3QZtwj+JQovVdU= X-Google-Smtp-Source: ABdhPJySxHjK9XxwDJnFQN4DvhgJhASkwz/NHGoO8h3oIBKNCRR+t8iWEXyH5O1Z018vigBdL2M9HQ== X-Received: by 2002:a37:bfc1:: with SMTP id p184mr15321144qkf.207.1592228811377; Mon, 15 Jun 2020 06:46:51 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id 124sm10100237qkn.45.2020.06.15.06.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 06:46:50 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.93) (envelope-from ) id 1jkpRq-008aTM-EI; Mon, 15 Jun 2020 10:46:50 -0300 Date: Mon, 15 Jun 2020 10:46:50 -0300 From: Jason Gunthorpe To: refactormyself@gmail.com Message-ID: <20200615134650.GA2030477@ziepe.ca> References: <20200615073225.24061-1-refactormyself@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615073225.24061-1-refactormyself@gmail.com> Cc: Don Brace , Sam Bobroff , Mike Marciniszyn , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, Dennis Dalessandro , Russell Currey , esc.storagedev@microsemi.com, Doug Ledford , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Vinod Koul , helgaas@kernel.org, Oliver O'Halloran , linuxppc-dev@lists.ozlabs.org, "James E.J. Bottomley" , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH 0/8 v2] PCI: Align return values of PCIe capability and PCI accessors X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Jun 15, 2020 at 09:32:17AM +0200, refactormyself@gmail.com wrote: > From: Bolarinwa Olayemi Saheed > > > PATCH 1/8 to 7/8: > PCIBIOS_ error codes have positive values and they are passed down the > call heirarchy from accessors. For functions which are meant to return > only a negative value on failure, passing on this value is a bug. > To mitigate this, call pcibios_err_to_errno() before passing on return > value from PCIe capability accessors call heirarchy. This function > converts any positive PCIBIOS_ error codes to negative generic error > values. > > PATCH 8/8: > The PCIe capability accessors can return 0, -EINVAL, or any PCIBIOS_ error > code. The pci accessor on the other hand can only return 0 or any PCIBIOS_ > error code.This inconsistency among these accessor makes it harder for > callers to check for errors. > Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all PCIe > capability accessors. > > MERGING: > These may all be merged via the PCI tree, since it is a collection of > similar fixes. This way they all get merged at once. I prefer this not happen for active trees, it just risks needless merge conflicts. I will take the hfi1 patches at least, let me know when they are reviewed Thanks, Jason _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees