From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA9FC433E5 for ; Mon, 13 Jul 2020 13:22:42 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5F72206F4 for ; Mon, 13 Jul 2020 13:22:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hlFk02nn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5F72206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8EDBA8908C; Mon, 13 Jul 2020 13:22:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JfDqTh-l+Nj1; Mon, 13 Jul 2020 13:22:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id A293188FFC; Mon, 13 Jul 2020 13:22:40 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 87A1CC0888; Mon, 13 Jul 2020 13:22:40 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6FBC4C0733 for ; Mon, 13 Jul 2020 13:22:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5D21388A89 for ; Mon, 13 Jul 2020 13:22:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O0wVDuG28E3e for ; Mon, 13 Jul 2020 13:22:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id D299C88A60 for ; Mon, 13 Jul 2020 13:22:37 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id bm28so11679008edb.2 for ; Mon, 13 Jul 2020 06:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=TEh/JkkBeDq0BmwWDLkY2ALcEwIhER9cNUR1loI6e78=; b=hlFk02nnRr+rQKvpcmIRPBcv9Vppks3wU3BsbHQlS35RNRr0Lm2YUw7/utWjHu70OH fu21BCriHQitKJ9VJJ9HkQBoc0oNiPianJ9DfryJ5s4iB77Gi9+P+wSDFA8dw7sDMdjN CRk+C/cn77UZdk8p4eMVCYK2N1kZ9NOWbvXAMsA8NoetiFgB4PjRem+NJr8k6FdLryN7 KSXqy55pf7Mo7GW41Rrh43kHUodvpJcq7yyqbdwHNICmnMteEU7rrwF/z8u+pZc3nMOJ t5bRIsTEDAnzpyq0Z/t5ptBct6erL48Bl/rPmxQHyXzHf8lqWgUjMDOqwGt/I2ULZZSO jYxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TEh/JkkBeDq0BmwWDLkY2ALcEwIhER9cNUR1loI6e78=; b=cOWE17wq5FlBKeYrtX1UAb401sM4NykOJ9bGUS6SQ2VoDe56MpsnAzdinPc540EaDc O0xZPvXaR3su2UdgLmYKTGHAd3pSor6P7rq391TT0vt6KLxGd6wJmmB38WXf8TwU03Vw Fxyi758DSMqtxkUjuNC0VRsg79Vi+y4p14G+OHoLkiX9sFB8c4ry6O7xC6uNiVxLrMgx lIMgYV7C50HdZB//KUB4hMLLXVtHd3v7gtnOjaxoOYDZ1mWuQwHfxU8iUnE6XDjiLrOm rtXWt/Pd05vnHEI0iiWqWpDkpA5ZlNytfRaUWE8Ou67M7sTlobkEY/co+9OCt/Rbvx4P Jw/g== X-Gm-Message-State: AOAM531zEBiFOloj7d4sRYQcZY8OLGpUVIYTd1n+dUBMwiz9hgnL8YHe R565ZECnFlMJ0qpFEEdxdlM= X-Google-Smtp-Source: ABdhPJw69dKLZM419xxp02IeffDX2nQ+F52A+jh3cXUOZ7YUfQhM+G+xXauU5Oq4EhNqFD1PfU4cXQ== X-Received: by 2002:a50:fb93:: with SMTP id e19mr83849853edq.106.1594646556147; Mon, 13 Jul 2020 06:22:36 -0700 (PDT) Received: from net.saheed (54007186.dsl.pool.telekom.hu. [84.0.113.134]) by smtp.gmail.com with ESMTPSA id n9sm11806540edr.46.2020.07.13.06.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 06:22:35 -0700 (PDT) From: "Saheed O. Bolarinwa" To: helgaas@kernel.org Date: Mon, 13 Jul 2020 14:22:12 +0200 Message-Id: <20200713122247.10985-1-refactormyself@gmail.com> X-Mailer: git-send-email 2.18.2 Cc: Rich Felker , "Martin K. Petersen" , linux-sh@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, Yicong Yang , Keith Busch , netdev@vger.kernel.org, Paul Mackerras , linux-i2c@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, sparclinux@vger.kernel.org, rfi@lists.rocketboards.org, Toan Le , Greg Ungerer , Marek Vasut , Rob Herring , Stefano Stabellini , Sagi Grimberg , Yoshinori Sato , linux-scsi@vger.kernel.org, Michael Ellerman , linux-atm-general@lists.sourceforge.net, Russell King , Realtek linux nic maintainers , Christoph Hellwig , Ley Foon Tan , Geert Uytterhoeven , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Chas Williams <3chas3@gmail.com>, Benjamin Herrenschmidt , xen-devel@lists.xenproject.org, Matt Turner , linux-mips@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Kevin Hilman , Guenter Roeck , linux-hwmon@vger.kernel.org, Jean Delvare , Andrew Donnellan , Arnd Bergmann , Ray Jui , "James E.J. Bottomley" , Yue Wang , Jens Axboe , Jakub Kicinski , linux-m68k@lists.linux-m68k.org, Lorenzo Pieralisi , Ivan Kokshaysky , Michael Buesch , linux-amlogic@lists.infradead.org, Boris Ostrovsky , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Richard Henderson , Juergen Gross , Michal Simek , Thomas Bogendoerfer , Scott Branden , Bjorn Helgaas , Jingoo Han , "Saheed O. Bolarinwa" , Yoshihiro Shimoda , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Brian King , Philipp Zabel , linux-alpha@vger.kernel.org, Frederic Barrat , Gustavo Pimentel , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Heiner Kallweit Subject: [Linux-kernel-mentees] [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86 X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" This goal of these series is to move the definition of *all* PCIBIOS* from include/linux/pci.h to arch/x86 and limit their use within there. All other tree specific definition will be left for intact. Maybe they can be renamed. PCIBIOS* is an x86 concept as defined by the PCI spec. The returned error codes of PCIBIOS* are positive values and this introduces some complexities which other archs need not incur. PLAN: 1. [PATCH v0 1-36] Replace all PCIBIOS_SUCCESSFUL with 0 2a. Audit all functions returning PCIBIOS_* error values directly or indirectly and prevent possible bug coming in (2b) 2b. Make all functions returning PCIBIOS_* error values call pcibios_err_to_errno(). *This will change their behaviour, for good.* 3. Clone a pcibios_err_to_errno() into arch/x86/pci/pcbios.c as _v2. This handles the positive error codes directly and will not use any PCIBIOS* definitions. So calls to it have no outside dependence. 4. Make all x86 codes that needs to convert to -E* values call the cloned version - pcibios_err_to_errno_v2() 5. Assign PCIBIOS_* errors values directly to generic -E* errors 6. Refactor pcibios_err_to_errno() and mark it deprecated 7. Replace all calls to pcibios_err_to_errno() with the proper -E* value or 0. 8. Remove all PCIBIOS* definitions in include/linux/pci.h and pcibios_err_to_errno() too. 9. Redefine all PCIBIOS* definitions with original values inside arch/x86/pci/pcbios.c 10. Redefine pcibios_err_to_errno() inside arch/x86/pci/pcbios.c 11. Replace pcibios_err_to_errno_v2() calls with pcibios_err_to_errno() 12. Remove pcibios_err_to_errno_v2() Suggested-by: Bjorn Helgaas Suggested-by: Yicong Yang Signed-off-by: "Saheed O. Bolarinwa" Bolarinwa Olayemi Saheed (35): Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Fix Style ERROR: assignment in if condition Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks Change PCIBIOS_SUCCESSFUL to 0 Tidy Success/Failure checks arch/alpha/kernel/core_apecs.c | 4 +-- arch/alpha/kernel/core_cia.c | 4 +-- arch/alpha/kernel/core_irongate.c | 4 +-- arch/alpha/kernel/core_lca.c | 4 +-- arch/alpha/kernel/core_marvel.c | 4 +-- arch/alpha/kernel/core_mcpcia.c | 4 +-- arch/alpha/kernel/core_polaris.c | 4 +-- arch/alpha/kernel/core_t2.c | 4 +-- arch/alpha/kernel/core_titan.c | 4 +-- arch/alpha/kernel/core_tsunami.c | 4 +-- arch/alpha/kernel/core_wildfire.c | 4 +-- arch/alpha/kernel/sys_miata.c | 2 +- arch/arm/common/it8152.c | 4 +-- arch/arm/mach-cns3xxx/pcie.c | 2 +- arch/arm/mach-footbridge/dc21285.c | 4 +-- arch/arm/mach-iop32x/pci.c | 6 ++-- arch/arm/mach-ixp4xx/common-pci.c | 8 ++--- arch/arm/mach-orion5x/pci.c | 4 +-- arch/arm/plat-orion/pcie.c | 8 ++--- arch/m68k/coldfire/pci.c | 8 ++--- arch/microblaze/pci/indirect_pci.c | 4 +-- arch/mips/pci/fixup-ath79.c | 2 +- arch/mips/pci/ops-bcm63xx.c | 14 ++++---- arch/mips/pci/ops-bonito64.c | 4 +-- arch/mips/pci/ops-gt64xxx_pci0.c | 4 +-- arch/mips/pci/ops-lantiq.c | 4 +-- arch/mips/pci/ops-loongson2.c | 4 +-- arch/mips/pci/ops-mace.c | 4 +-- arch/mips/pci/ops-msc.c | 4 +-- arch/mips/pci/ops-rc32434.c | 6 ++-- arch/mips/pci/ops-sni.c | 4 +-- arch/mips/pci/ops-tx3927.c | 2 +- arch/mips/pci/ops-tx4927.c | 2 +- arch/mips/pci/ops-vr41xx.c | 4 +-- arch/mips/pci/pci-alchemy.c | 6 ++-- arch/mips/pci/pci-ar2315.c | 5 ++- arch/mips/pci/pci-ar71xx.c | 4 +-- arch/mips/pci/pci-ar724x.c | 6 ++-- arch/mips/pci/pci-bcm1480.c | 4 +-- arch/mips/pci/pci-bcm1480ht.c | 4 +-- arch/mips/pci/pci-mt7620.c | 4 +-- arch/mips/pci/pci-octeon.c | 12 +++---- arch/mips/pci/pci-rt2880.c | 4 +-- arch/mips/pci/pci-rt3883.c | 4 +-- arch/mips/pci/pci-sb1250.c | 4 +-- arch/mips/pci/pci-virtio-guest.c | 4 +-- arch/mips/pci/pci-xlp.c | 4 +-- arch/mips/pci/pci-xlr.c | 4 +-- arch/mips/pci/pci-xtalk-bridge.c | 14 ++++---- arch/mips/pci/pcie-octeon.c | 4 +-- arch/mips/txx9/generic/pci.c | 5 ++- arch/powerpc/kernel/rtas_pci.c | 4 +-- arch/powerpc/platforms/4xx/pci.c | 4 +-- arch/powerpc/platforms/52xx/efika.c | 4 +-- arch/powerpc/platforms/52xx/mpc52xx_pci.c | 4 +-- arch/powerpc/platforms/82xx/pq2.c | 2 +- arch/powerpc/platforms/85xx/mpc85xx_cds.c | 2 +- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +- arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- arch/powerpc/platforms/chrp/pci.c | 8 ++--- arch/powerpc/platforms/embedded6xx/holly.c | 2 +- .../platforms/embedded6xx/mpc7448_hpc2.c | 2 +- arch/powerpc/platforms/fsl_uli1575.c | 2 +- arch/powerpc/platforms/maple/pci.c | 18 +++++----- arch/powerpc/platforms/pasemi/pci.c | 6 ++-- arch/powerpc/platforms/powermac/pci.c | 8 ++--- arch/powerpc/platforms/powernv/eeh-powernv.c | 4 +-- arch/powerpc/platforms/powernv/pci.c | 4 +-- arch/powerpc/platforms/pseries/eeh_pseries.c | 4 +-- arch/powerpc/sysdev/fsl_pci.c | 2 +- arch/powerpc/sysdev/indirect_pci.c | 4 +-- arch/powerpc/sysdev/tsi108_pci.c | 4 +-- arch/sh/drivers/pci/common.c | 3 +- arch/sh/drivers/pci/ops-dreamcast.c | 4 +-- arch/sh/drivers/pci/ops-sh4.c | 4 +-- arch/sh/drivers/pci/ops-sh7786.c | 8 ++--- arch/sh/drivers/pci/pci.c | 2 +- arch/sparc/kernel/pci_common.c | 28 +++++++-------- arch/unicore32/kernel/pci.c | 4 +-- drivers/atm/iphase.c | 20 ++++++----- drivers/atm/lanai.c | 8 ++--- drivers/bcma/driver_pci_host.c | 4 +-- drivers/hwmon/sis5595.c | 13 +++---- drivers/hwmon/via686a.c | 13 +++---- drivers/hwmon/vt8231.c | 13 +++---- drivers/i2c/busses/i2c-ali15x3.c | 5 ++- drivers/i2c/busses/i2c-nforce2.c | 3 +- drivers/i2c/busses/i2c-sis5595.c | 15 +++----- drivers/misc/cxl/vphb.c | 4 +-- drivers/net/ethernet/realtek/r8169_main.c | 2 +- drivers/nvme/host/pci.c | 2 +- drivers/pci/access.c | 14 ++++---- drivers/pci/controller/dwc/pci-meson.c | 4 +-- .../pci/controller/dwc/pcie-designware-host.c | 2 +- drivers/pci/controller/dwc/pcie-designware.c | 4 +-- drivers/pci/controller/dwc/pcie-hisi.c | 4 +-- drivers/pci/controller/dwc/pcie-tegra194.c | 4 +-- .../pci/controller/mobiveil/pcie-mobiveil.c | 4 +-- drivers/pci/controller/pci-aardvark.c | 4 +-- drivers/pci/controller/pci-ftpci100.c | 4 +-- drivers/pci/controller/pci-hyperv.c | 8 ++--- drivers/pci/controller/pci-mvebu.c | 4 +-- drivers/pci/controller/pci-thunder-ecam.c | 36 +++++++++---------- drivers/pci/controller/pci-thunder-pem.c | 4 +-- drivers/pci/controller/pci-xgene.c | 5 ++- drivers/pci/controller/pcie-altera.c | 16 ++++----- drivers/pci/controller/pcie-iproc.c | 10 +++--- drivers/pci/controller/pcie-mediatek.c | 4 +-- drivers/pci/controller/pcie-rcar-host.c | 8 ++--- drivers/pci/controller/pcie-rockchip-host.c | 10 +++--- drivers/pci/pci-bridge-emul.c | 14 ++++---- drivers/pci/pci.c | 8 ++--- drivers/pci/pcie/bw_notification.c | 4 +-- drivers/pci/probe.c | 4 +-- drivers/pci/quirks.c | 4 +-- drivers/pci/syscall.c | 8 ++--- drivers/pci/xen-pcifront.c | 2 +- drivers/scsi/ipr.c | 16 ++++----- drivers/scsi/pmcraid.c | 6 ++-- drivers/ssb/driver_gige.c | 4 +-- drivers/ssb/driver_pcicore.c | 4 +-- drivers/xen/xen-pciback/conf_space.c | 2 +- 122 files changed, 347 insertions(+), 369 deletions(-) -- 2.18.2 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees