From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38E8AC433DF for ; Fri, 21 Aug 2020 05:23:19 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDD0A21744 for ; Fri, 21 Aug 2020 05:23:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfmN6vb4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDD0A21744 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id C5CBD86CF4; Fri, 21 Aug 2020 05:23:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1wx-kmt28zIf; Fri, 21 Aug 2020 05:23:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6E0CC86CA6; Fri, 21 Aug 2020 05:23:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5A99CC07FF; Fri, 21 Aug 2020 05:23:18 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id A8F0FC0051 for ; Fri, 21 Aug 2020 05:23:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 97B8886CF4 for ; Fri, 21 Aug 2020 05:23:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PQymG4EC-qeT for ; Fri, 21 Aug 2020 05:23:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 1E7E986CA6 for ; Fri, 21 Aug 2020 05:23:16 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id h12so461482pgm.7 for ; Thu, 20 Aug 2020 22:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kIrZF45/BAvVQh8mbn5wXf5JnEyRG1slRn5cBPdhKss=; b=DfmN6vb4B8kr6tDcwzZIlusSYb6WCJA3RduM6NIddsXJ65ZCz0UVsNaSyZ/NUR94yX ad0zV3EMKOJ83IR0u+lHcjAwgFJDJKkeH8FmYfKUKTx8pEf/X9xczjahG5CklZRDaYt8 LGWLqc39N+77WCD/ZUtlc0C2QUrBUbV/3Cp95Y2kGvBEF/Je37P3NW8CK/uZ0psozI2W Njup1s9Cp5s4PD4P24sGOxLs4YGeB9pgtv7xzwS9RKjuBetZSzMD8hENsgFAwHcyxgTD A/6NranznkC+nF4OyGfyN1j0af4E4UTcwGaAvyfxYW/tksZsXad+V5CDtj+USGPUUaNb 5ruw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kIrZF45/BAvVQh8mbn5wXf5JnEyRG1slRn5cBPdhKss=; b=K88RX2YuAmYmAAPkBK6ob6D6OZLgWjB16jIj3D2neEKu2D9Yt1051EtW7BJTelWfUI Z3hw1Tju+PSnCYJ+v7Nz4+eVT918WDEq3QstcjSsdm/Rqteefgacahjcw6ew8cqH5NRH mZzskHf3xndK8I/Kv5IFoSyqUOpYoKdbYHmtiPrTTje+CQ0p0uEFkGTJndl562DDnLiw 0Pp2IZnSflgpIG0S/xXSE+Ck3YqCH1TfXLY/LyYIlmRDcSpCBxcN6gG9rE5OHOjAhzL0 ZYHtTusdOz8m5GsFmTDt+EGCLjHE5ELM6D4OprCzCyuwN0Ylz3XADVSf2sZgTBltXWmU E9qg== X-Gm-Message-State: AOAM532lLQnBykioMUJAuzMK6e9iMLLO7LUfPTpvUx8efCGbdxvY4RGw uiSDh/asressCvsLGWAhSQc= X-Google-Smtp-Source: ABdhPJwGMTHU2migh+Vtz36GIcyJKI0+/w+/wl9eaIpMSvJqvm5WwNJmFhE51zJndWVMYSVxv0mnRw== X-Received: by 2002:a62:3583:: with SMTP id c125mr1136819pfa.1.1597987395542; Thu, 20 Aug 2020 22:23:15 -0700 (PDT) Received: from f3 (ae055068.dynamic.ppp.asahi-net.or.jp. [14.3.55.68]) by smtp.gmail.com with ESMTPSA id l7sm593466pjf.43.2020.08.20.22.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2020 22:23:14 -0700 (PDT) Date: Fri, 21 Aug 2020 14:23:08 +0900 From: Benjamin Poirier To: Coiby Xu Message-ID: <20200821052308.GA12235@f3> References: <20200814160601.901682-1-coiby.xu@gmail.com> <20200814160601.901682-2-coiby.xu@gmail.com> <20200816025640.GA27529@f3> <20200821030822.huyuxa5o5tcvtv2o@Rk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821030822.huyuxa5o5tcvtv2o@Rk> Cc: Michal Kubecek , "open list:STAGING SUBSYSTEM" , GR-Linux-NIC-Dev@marvell.com, Manish Chopra , netdev@vger.kernel.org, open list , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [RFC 1/3] Initialize devlink health dump framework for the dlge driver X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On 2020-08-21 11:08 +0800, Coiby Xu wrote: [...] > > > diff --git a/drivers/staging/qlge/qlge_health.h b/drivers/staging/qlge/qlge_health.h > > > new file mode 100644 > > > index 000000000000..07d3bafab845 > > > --- /dev/null > > > +++ b/drivers/staging/qlge/qlge_health.h > > > @@ -0,0 +1,2 @@ > > > +#include > > > +int qlge_health_create_reporters(struct qlge_devlink *priv); > > > > I would suggest to put this in qlge.h instead of creating a new file. > > Although there are only two lines for now, is it possible qlge will add > more devlink code? If that's the case, a file to single out these code I would say that if there's more content in the future, it can move to a separate file in the future. If you feel strongly about putting this in its own file right away, then make sure to add the usual #ifndef QLGE_HEALTH_H #define QLGE_HEALTH_H ... _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees