From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42063C433DF for ; Fri, 21 Aug 2020 12:28:58 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1540E20724 for ; Fri, 21 Aug 2020 12:28:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1540E20724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E10EA86D47; Fri, 21 Aug 2020 12:28:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JQ4i9lk-7Kw7; Fri, 21 Aug 2020 12:28:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 738178698B; Fri, 21 Aug 2020 12:28:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 63F94C07FF; Fri, 21 Aug 2020 12:28:57 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 01512C0051 for ; Fri, 21 Aug 2020 12:28:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id E449B886A0 for ; Fri, 21 Aug 2020 12:28:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KwJvJUg3cjiR for ; Fri, 21 Aug 2020 12:28:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by hemlock.osuosl.org (Postfix) with ESMTPS id 3C2CD8869D for ; Fri, 21 Aug 2020 12:28:55 +0000 (UTC) IronPort-SDR: nTGR6jrnVWNa5bFV4JaVC3Z6waEVf7wjvfyYEwGeHe5vzp17qOi638557MrGLWMSrNrUeUQftC Cc/lCkMXK+6g== X-IronPort-AV: E=McAfee;i="6000,8403,9719"; a="240341118" X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="240341118" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 05:28:54 -0700 IronPort-SDR: XrWEwKuYz0KCi67K2ashjHljtoVSK06/hUXjxtueO34msSzCeU1kuj1+pRGaf3NL891STiS72d AzzjiLroS4zw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,335,1592895600"; d="scan'208";a="327750343" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 21 Aug 2020 05:28:51 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k96A5-00ALOl-9g; Fri, 21 Aug 2020 15:28:49 +0300 Date: Fri, 21 Aug 2020 15:28:49 +0300 From: Andy Shevchenko To: Petr Mladek Message-ID: <20200821122849.GS1891694@smile.fi.intel.com> References: <20200817043028.76502-1-98.arpi@gmail.com> <20200821113710.GA26290@alley> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200821113710.GA26290@alley> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: Arpitha Raghunandan <98.arpi@gmail.com>, brendanhiggins@google.com, Rasmus Villemoes , linux-kernel@vger.kernel.org, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux-kselftest@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, kunit-dev@googlegroups.com Subject: Re: [Linux-kernel-mentees] [PATCH] lib: Convert test_printf.c to KUnit X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Fri, Aug 21, 2020 at 01:37:10PM +0200, Petr Mladek wrote: > On Mon 2020-08-17 09:06:32, Rasmus Villemoes wrote: > > On 17/08/2020 06.30, Arpitha Raghunandan wrote: > > > Converts test lib/test_printf.c to KUnit. > > > More information about KUnit can be found at > > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html. > > > KUnit provides a common framework for unit tests in the kernel. > > > > So I can continue to build a kernel with some appropriate CONFIG set to > > y, boot it under virt-me, run dmesg and see if I broke printf? That's > > what I do now, and I don't want to have to start using some enterprisy > > framework. > > I had the same concern. I have tried it. Which raises an obvious question: did the people who convert this test this themselves? Looks like a janitor work in the area without understanding the area good enough. Probably I will NAK all those patches from now on, until it will be good commit messages and cover of risen aspects, including reference to before and after outcome for passed and failed test cases. Brendan, I guess the ball now on your side to prove this is good activity. -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees