From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D05C433E1 for ; Thu, 27 Aug 2020 09:43:34 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A6AD207CD for ; Thu, 27 Aug 2020 09:43:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="C8IZPMln" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A6AD207CD Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0463387FD8; Thu, 27 Aug 2020 09:43:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eBm4VpnsfYqs; Thu, 27 Aug 2020 09:43:33 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 85E5287EA2; Thu, 27 Aug 2020 09:43:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 708C7C016F; Thu, 27 Aug 2020 09:43:33 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id CCED5C0051 for ; Thu, 27 Aug 2020 09:43:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B53CD87FD8 for ; Thu, 27 Aug 2020 09:43:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xqambry2AdI4 for ; Thu, 27 Aug 2020 09:43:31 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by hemlock.osuosl.org (Postfix) with ESMTPS id 1FD9B87EA2 for ; Thu, 27 Aug 2020 09:43:31 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3642A20738; Thu, 27 Aug 2020 09:43:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598521410; bh=6swQyYkYC4Z1c7XhfVxkd28d4ymWKX09l25zxnCPTsE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C8IZPMlnAgOmvHfdnp2bPcQKpKbf6aDNvCVOyQIEPnvCwsAnUVB5t0wB/c5LBdhYL rI5R5iGtVyxlKvWSqLhj1lmmgmenPFV3ArvZ5OZPe01s63M4gz7qhkj9P5oC7jjGw9 ER7wvatdCzNUCXRlIm3KKt8fh+18Ckx/3dAQrmeM= Date: Thu, 27 Aug 2020 11:43:44 +0200 From: Greg KH To: Mrinal Pandey Message-ID: <20200827094344.GA400189@kroah.com> References: <20200827092405.b6hymjxufn2nvgml@mrinalpandey> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200827092405.b6hymjxufn2nvgml@mrinalpandey> Cc: keescook@chromium.org, kernel-hardening@lists.openwall.com, linux-spdx@vger.kernel.org, maennich@google.com, linux-kernel@vger.kernel.org, re.emese@gmail.com, tglx@linutronix.de, Linux-kernel-mentees@lists.linuxfoundation.org, akpm@linux-foundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] scripts: Add intended executable mode and SPDX license X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Aug 27, 2020 at 02:54:05PM +0530, Mrinal Pandey wrote: > commit b72231eb7084 ("scripts: add spdxcheck.py self test") added the file > spdxcheck-test.sh to the repository without the executable flag and license > information. > > commit eb8305aecb95 ("scripts: Coccinelle script for namespace > dependencies.") added the file nsdeps, commit 313dd1b62921 ("gcc-plugins: > Add the randstruct plugin") added the file gcc-plugins/gen-random-seed.sh > and commit 9b4ade226f74 ("xen: build infrastructure for generating > hypercall depending symbols") added the file xen-hypercalls.sh without the > executable bit. > > Set to usual modes for these files and provide the SPDX license for > spdxcheck-test.sh. No functional changes. > > Signed-off-by: Mrinal Pandey > --- > applies cleanly on next-20200827 > > Kees, Matthias, Thomas, please ack this patch. > > Andrew, please pick this minor non-urgent cleanup patch once the > mainainers ack. > > scripts/gcc-plugins/gen-random-seed.sh | 0 > scripts/nsdeps | 0 > scripts/spdxcheck-test.sh | 1 + > scripts/xen-hypercalls.sh | 0 > 4 files changed, 1 insertion(+) > mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh > mode change 100644 => 100755 scripts/nsdeps > mode change 100644 => 100755 scripts/spdxcheck-test.sh > mode change 100644 => 100755 scripts/xen-hypercalls.sh This does 2 different things in one patch, shouldn't this be 2 different patches? One to change the permissions and one to add the SPDX line? thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees