From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF43DC2BC11 for ; Mon, 14 Sep 2020 11:08:14 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDFC2208DB for ; Mon, 14 Sep 2020 11:08:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TkCOOe1D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDFC2208DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7F9BA86914; Mon, 14 Sep 2020 11:08:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YnwF7E2Dm0RK; Mon, 14 Sep 2020 11:08:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id BE12E868E5; Mon, 14 Sep 2020 11:08:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A5017C0864; Mon, 14 Sep 2020 11:08:10 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 46BD7C0051 for ; Mon, 14 Sep 2020 11:08:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 386FE20470 for ; Mon, 14 Sep 2020 11:08:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aYdCeEWhZfh2 for ; Mon, 14 Sep 2020 11:08:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by silver.osuosl.org (Postfix) with ESMTPS id 66171203A4 for ; Mon, 14 Sep 2020 11:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R3WQcbK1OYupOiZx/4aRKRWUnmzNcweOP1HOOsSlSWU=; b=TkCOOe1DWoOM+uWKWkJZWxo9oD kqJ7qOtuibBqqE6cz5MQssWjL0fhXofYGJHn60PJEkdsLwjUSdo4O90gd+4J7mMFw17z+1Xu++JbS Gi8Zv+v+uSAPWwOVL+458uKf07DKJ+cBRDNd7ncoIR2Ua+tYTiJ9GJ0TRPxVjmucZCZPlkoJQaldy wbatSlKrssuvitaz2/VjlhfZK2svX0dFEZlSc0rcCj6mK+HZgKFhsftYqJw210I4xVHHBXgka2OLp ZDKDrkaLtuvPZfdV/FfXSYRDE9Ma+3Cc4unIyIrelx2ZNV44gV0DcIkLqbsZgC1032RKRj7T3gFvA T+Oi3tHg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHmL6-0004bO-15; Mon, 14 Sep 2020 11:08:04 +0000 Date: Mon, 14 Sep 2020 12:08:03 +0100 From: Matthew Wilcox To: Anmol Karn Message-ID: <20200914110803.GL6583@casper.infradead.org> References: <20200914071724.202365-1-anmol.karan123@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914071724.202365-1-anmol.karan123@gmail.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com Subject: Re: [Linux-kernel-mentees] [PATCH] idr: remove WARN_ON_ONCE() when trying to check id X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Sep 14, 2020 at 12:47:24PM +0530, Anmol Karn wrote: > idr_get_next() gives WARN_ON_ONCE() when it gets (id > INT_MAX) true > and this happens when syzbot does fuzzing, and that warning is > expected, but WARN_ON_ONCE() is not required here and, cecking > the condition and returning NULL value would be suffice. > > Reference: commit b9959c7a347 ("filldir[64]: remove WARN_ON_ONCE() for bad directory entries") > Reported-and-tested-by: syzbot+f7204dcf3df4bb4ce42c@syzkaller.appspotmail.com > Link: https://syzkaller.appspot.com/bug?extid=f7204dcf3df4bb4ce42c > Signed-off-by: Anmol Karn https://lore.kernel.org/netdev/20200605120037.17427-1-willy@infradead.org/ _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees