Re: [PATCH] rxrpc: fix bad unlock balance in rxrpc_do_sendmsg

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Khalid Masum <khalid.masum.92@gmail.com>
Cc: "open list:NETWORKING \[GENERAL\]" <netdev@vger.kernel.org>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-afs@lists.infradead.org,
	David Howells <dhowells@redhat.com>,
	syzbot+7f0483225d0c94cb3441@syzkaller.appspotmail.com,
	Eric Dumazet <edumazet@google.com>,
	Pavel Skripkin <paskripkin@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Marc Dionne <marc.dionne@auristor.com>,
	Hawkins Jiawei <yin31149@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>,
	linux-kernel-mentees
	<linux-kernel-mentees@lists.linuxfoundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] rxrpc: fix bad unlock balance in rxrpc_do_sendmsg
Date: Mon, 22 Aug 2022 17:05:32 +0300	[thread overview]
Message-ID: <20220822140532.GF2695@kadam> (raw)
In-Reply-To: <CAABMjtE-XKa-_kW-aREvHDiyGwcs-GZWjtSjZEeF577FKcUTAA@mail.gmail.com>

On Mon, Aug 22, 2022 at 07:55:27PM +0600, Khalid Masum wrote:
> >
> > /*
> > + * @holding_mutex: An indication whether caller can still holds
> > + * the call->user_mutex when returned to caller.
> 
> Maybe we can use mutex_is_locked instead of using the holding_mutex
> parameter to get whether call->user_mutex is still held.

That doesn't work.  What if there is contention for the lock and someone
else took it.  Locks under contention are sort of the whole point of
locking so it's highly likely.

I do kind of feel the code has a layering violation.  I'd prefer instead
of "I am setting this variable to true to reflect the caller blah blah",
the variable could just be set in the caller.  I'd probably flip it
around and call it "dropped_lock" instead of "holding_lock".

	bool dropped_lock = false;

	...

	if (!dropped_lock)
		mutex_unlock();

That way only the callers and the function which drops the lock need to
be involved with setting the variable.

regards,
dan carpenter

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees