From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB8B4C04A6A for ; Fri, 4 Aug 2023 05:15:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 699AF4002D; Fri, 4 Aug 2023 05:15:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 699AF4002D Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=RFNvgdxK X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6d0lz1CGWpJt; Fri, 4 Aug 2023 05:15:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 1C33D40920; Fri, 4 Aug 2023 05:15:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1C33D40920 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id EA1CAC0072; Fri, 4 Aug 2023 05:15:48 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 36037C0032 for ; Fri, 4 Aug 2023 05:15:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0BA6680E45 for ; Fri, 4 Aug 2023 05:15:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0BA6680E45 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=RFNvgdxK X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QCWy14L9PgTM for ; Fri, 4 Aug 2023 05:15:47 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 3E120812B9 for ; Fri, 4 Aug 2023 05:15:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3E120812B9 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8418861F2E; Fri, 4 Aug 2023 05:15:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D3B8C433C8; Fri, 4 Aug 2023 05:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691126146; bh=USmLM7XlRgBQi58d1O7rkZwpAoU1QZU1TYBFKp261ss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RFNvgdxKrimI8wHa+gINMl4wknnhcFE7xlFV+zDo9HVifudBf+5/8Xl3YKW289F7+ xM/BMTI7P8TClWhZ+M+fiP3p7tXyaHTNbj97ayBPNOwNKFRO6ADdRlknO1gTT+076m J9fVXeGFEOG2aKGoBK9cyEDVflbGM+mrzeLshpUc= Date: Fri, 4 Aug 2023 07:15:43 +0200 From: Greg KH To: Atul Raut Subject: Re: [PATCH v2] ath6kl: replace one-element array with flexible-array member Message-ID: <2023080433-patio-staining-2cfe@gregkh> References: <20230804045554.6934-1-rauji.raut@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230804045554.6934-1-rauji.raut@gmail.com> Cc: linux-wireless@vger.kernel.org, kvalo@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Aug 03, 2023 at 09:55:54PM -0700, Atul Raut wrote: > One-element arrays are no longer relevant, and their > place has been taken by flexible array members thus, > use a flexible-array member to replace the one-element > array in struct ath6kl_usb_ctrl_diag_cmd_write > > This fixes warnings such as: > ./drivers/net/wireless/ath/ath6kl/usb.c:109:8-12: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays) > > Signed-off-by: Atul Raut > --- > drivers/net/wireless/ath/ath6kl/usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c > index 5220809841a6..c8ecc9e85897 100644 > --- a/drivers/net/wireless/ath/ath6kl/usb.c > +++ b/drivers/net/wireless/ath/ath6kl/usb.c > @@ -106,7 +106,7 @@ struct ath6kl_usb_ctrl_diag_cmd_write { > __le32 cmd; > __le32 address; > __le32 value; > - __le32 _pad[1]; > + __le32 _pad[]; Are you sure this is actually a variable length array? And you just changed the size of this structure, are you sure this is correct? There have been lots of work on this type of thing in the past on the hardening mailing list, I suggest you work there with the developers to see if this is even a valid change first. thanks, greg k-h _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees