From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16AF7CDB461 for ; Wed, 11 Oct 2023 16:15:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9684360FEC; Wed, 11 Oct 2023 16:15:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9684360FEC Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bs0AcPB4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cr3g4MMADsRx; Wed, 11 Oct 2023 16:15:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 2108160FFE; Wed, 11 Oct 2023 16:15:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2108160FFE Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 04C36C0071; Wed, 11 Oct 2023 16:15:22 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D51E7C0032 for ; Wed, 11 Oct 2023 16:15:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B62AA404DF for ; Wed, 11 Oct 2023 16:15:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B62AA404DF Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=bs0AcPB4 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kmxYuzbRuvXW for ; Wed, 11 Oct 2023 16:15:19 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id ECF7F404CB for ; Wed, 11 Oct 2023 16:15:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org ECF7F404CB Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 40E8FCE23E7; Wed, 11 Oct 2023 16:15:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06ED6C433C8; Wed, 11 Oct 2023 16:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697040908; bh=wtQMMdHrnFggk0m06ilUhF5VMAOMImQU9UM40mHBiVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bs0AcPB4HUa9JKFIg7sdXg83lTzuhi2OLLs5zi4krsrYvKkFZflYBf5izlTEFYFOP YvFLiFb3wyNSQ6tsiAy8O8YdDaQto5/2ejA3/wlhLEJFh+DjPPnVsVn1yULSEB49cL VinmbeTTkJmHOe7f+Mw/vGKdY2McoxJ3LxjkVJEDbYjH4UgOQXIV1IQ6n5A7VWViqY 2djutKm3XqC32xhSqUTRM9doqqD/yVJBsJ+r6B8RN+V0zz+D6STCXNDgzOAFWFbN9r j3syNlYhPWWm/HhBeiCYETIqLjcBcDEQeSTIRAcABeASEW/tgv7tTS0ie/ooyVKydW 6qJwMIDqkj1tQ== Date: Wed, 11 Oct 2023 17:15:03 +0100 From: Conor Dooley To: Anshul Dalal Subject: Re: [PATCH v4 1/2] dt-bindings: input: bindings for Adafruit Seesaw Gamepad Message-ID: <20231011-powdering-recycled-71608e794eaa@spud> References: <20231010184827.1213507-1-anshulusr@gmail.com> MIME-Version: 1.0 In-Reply-To: <20231010184827.1213507-1-anshulusr@gmail.com> Cc: devicetree@vger.kernel.org, Conor Dooley , Dmitry Torokhov , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4447161630996643041==" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" --===============4447161630996643041== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="timCUOp0XhI+CNqU" Content-Disposition: inline --timCUOp0XhI+CNqU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey, On Wed, Oct 11, 2023 at 12:18:23AM +0530, Anshul Dalal wrote: > Adds bindings for the Adafruit Seesaw Gamepad. >=20 > The gamepad functions as an i2c device with the default address of 0x50 > and has an IRQ pin that can be enabled in the driver to allow for a rising > edge trigger on each button press or joystick movement. >=20 > Product page: > https://www.adafruit.com/product/5743 > Arduino driver: > https://github.com/adafruit/Adafruit_Seesaw >=20 > Signed-off-by: Anshul Dalal > --- >=20 > Changes for v4: > - Fixed the URI for the id field > - Added `interrupts` property >=20 > Changes for v3: > - Updated id field to reflect updated file name from previous version > - Added `reg` property >=20 > Changes for v2: > - Renamed file to `adafruit,seesaw-gamepad.yaml` > - Removed quotes for `$id` and `$schema` > - Removed "Bindings for" from the description > - Changed node name to the generic name "joystick" > - Changed compatible to 'adafruit,seesaw-gamepad' instead of > 'adafruit,seesaw_gamepad' >=20 > .../input/adafruit,seesaw-gamepad.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/adafruit,sees= aw-gamepad.yaml >=20 > diff --git a/Documentation/devicetree/bindings/input/adafruit,seesaw-game= pad.yaml b/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.= yaml > new file mode 100644 > index 000000000000..e8e676006d2f > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/adafruit,seesaw-gamepad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Adafruit Mini I2C Gamepad with seesaw Binding mostly looks good to me. My main question is what is a seesaw? > + > +maintainers: > + - Anshul Dalal > + > +description: | > + Adafruit Mini I2C Gamepad > + > + +-----------------------------+ > + | ___ | > + | / \ (X) | > + | | S | __ __ (Y) (A) | > + | \___/ |ST| |SE| (B) | > + | | > + +-----------------------------+ > + > + S -> 10-bit percision bidirectional analog joystick > + ST -> Start > + SE -> Select > + X, A, B, Y -> Digital action buttons > + > + Product page: https://www.adafruit.com/product/5743 > + Arduino Driver: https://github.com/adafruit/Adafruit_Seesaw I'm not really sure what the arduino driver has to do with the binding. Why is a link to it more relevant than the freebsd driver, or the linux driver etc? Is there info about how the pad works in the arduino driver Otherwise, this seems good to me. Thanks, Conor. > + > +properties: > + compatible: > + const: adafruit,seesaw-gamepad > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: > + The gamepad's IRQ pin triggers a rising edge if interrupts are ena= bled. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + joystick@50 { > + compatible =3D "adafruit,seesaw-gamepad"; > + reg =3D <0x50>; > + }; > + }; > --=20 > 2.42.0 >=20 --timCUOp0XhI+CNqU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSbKBwAKCRB4tDGHoIJi 0uPyAP44XQzOQbflxL/UvrKTR2YMG9/YIVQXQK5aBzNTEXcMUAEA8xyeLKAOZtJx HK4Pss8t1U8E5lZrti8sa9pDht76Bws= =wvkn -----END PGP SIGNATURE----- --timCUOp0XhI+CNqU-- --===============4447161630996643041== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees --===============4447161630996643041==--