Re: [PATCH v2] gen_compile_commands: fix invalid escape sequence warning

Justin Stitt
2024-02-14T00:31:59Z

On Tue, Feb 13, 2024 at 12:00 PM Nicolas Schier <nicolas@fjasle.eu> wrote:
>
> On Mon 12 Feb 2024 20:25:52 GMT, Andrew Ballance wrote:
> > with python 12.1 '\#' results in this warning
>
> funny typo: it's Python 3.12 :)

They probably meant Python 3.12.1 and forgot the "3." (or had a vim
moment resulting in its unfortunate removal)

>
> Kind regards,
> Nicolas
>
>
> > SyntaxWarning: invalid escape sequence '\#'
> >
> > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com>
> > ---
> > scripts/clang-tools/gen_compile_commands.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> > index 5dea4479240b..93f64095fda9 100755
> > --- a/scripts/clang-tools/gen_compile_commands.py
> > +++ b/scripts/clang-tools/gen_compile_commands.py
> > @@ -170,7 +170,7 @@ def process_line(root_directory, command_prefix, file_path):
> > # escape the pound sign '#', either as '\#' or '$(pound)' (depending on the
> > # kernel version). The compile_commands.json file is not interepreted
> > # by Make, so this code replaces the escaped version with '#'.
> > - prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#')
> > + prefix = command_prefix.replace('\\#', '#').replace('$(pound)', '#')
> >
> > # Return the canonical path, eliminating any symbolic links encountered in the path.
> > abs_path = os.path.realpath(os.path.join(root_directory, file_path))
> > --
> > 2.43.0
> >
>
> --
> Nicolas Schier
>
> epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc
> ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
> -- frykten for herren er opphav til kunnskap --