From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 800A684DF5 for ; Thu, 18 Jul 2024 15:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721316863; cv=none; b=SA5sdBVLH1DXnPvZ5jGrEK3Czb+/Txuq+nxLhnLifu//KGeSovVRRFn9UTL77YLN8M2LEf8qI0wrShV+Mo+qlo/OhhkydGHOJlhQsB9hJLb+5ueBJXyGrtWwXtR9rfRMJKaxNT8eKTEYtOCqWBvFS5NAXyaR0pyNi+L0iU6wLc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721316863; c=relaxed/simple; bh=d8p7JTSMNvZCbWgBO9OlvaoJIKaIcHFTnIofjqs4coY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HA4AsciTC4npNmZuigzvKodSof0q8kBt6jmJVpt5Eqj9EzT3ikPy9rVLiNBngdN+BXROQ7pXYBSsoZo9UrVFnuff0QJSDiP7IKTqVPYVNevtbmQi5GIeHGud593z2Qbfk7aNuhLuBkOUEKC1tEnq12CeqwqnO5X8BUk5bjJiZE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M2t2Xmhu; arc=none smtp.client-ip=140.211.166.133 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M2t2Xmhu" Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3705440EF0 for ; Thu, 18 Jul 2024 15:34:22 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org X-Spam-Flag: NO X-Spam-Score: -4.401 X-Spam-Level: Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id swqBNE3pB_9V for ; Thu, 18 Jul 2024 15:34:21 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=will@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org D38F34040D Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org D38F34040D Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=M2t2Xmhu Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id D38F34040D for ; Thu, 18 Jul 2024 15:34:20 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 97CFBCE19F1; Thu, 18 Jul 2024 15:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0903C116B1; Thu, 18 Jul 2024 15:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721316855; bh=d8p7JTSMNvZCbWgBO9OlvaoJIKaIcHFTnIofjqs4coY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M2t2XmhuV5HcuQvM7AcRwmwGB3C54/gs6iv9TwmMjv8U5IMM7fuRXuu/Mn8VQd9rF GJ3hUBs1H80+5VGwtbIg1tYCcWZ2AQmRfIlYiaPJbJZ/4695469zYGcu8FWijcaVDH hJayA+FovUBrisDLh0iOFcPMFEgp/xqRi23bU12layGfKGcJEMjruYYNmK7cTh+CSi VqoayXNXC3mJZS1+K48tozx7e98hgFzrN0EB1RylWUj3qQssCtpBdbn/nBq5ytMBn0 iQaTei8XjEFcpoYaI7f2xEGJVlElkCWHVojTBFo7MgPFBONdD4YePWFFYkQFanyRTG FPjhSJmumGdFg== Date: Thu, 18 Jul 2024 16:34:10 +0100 From: Will Deacon To: Dev Jain Cc: Remington Brasga , Catalin Marinas , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Anshuman.Khandual@arm.com, Mark Brown , Ryan Roberts Subject: Re: [PATCH] kselftest: missing arg in ptrace.c Message-ID: <20240718153410.GA21354@willie-the-truck> References: <20240712231730.2794-1-rbrasga@uci.edu> Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Tue, Jul 16, 2024 at 09:49:12AM +0530, Dev Jain wrote: > > On 7/13/24 04:47, Remington Brasga wrote: > > The string passed to ksft_test_result_skip is missing the `type_name` > > > > Signed-off-by: Remington Brasga > > --- > > clang-tidy reported clang-diagnostic-format-insufficient-args warning > > on this line, so I am fixing it. > > > > tools/testing/selftests/arm64/abi/ptrace.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c > > index abe4d58d731d..6144f83f8ab4 100644 > > --- a/tools/testing/selftests/arm64/abi/ptrace.c > > +++ b/tools/testing/selftests/arm64/abi/ptrace.c > > @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name) > > /* Zero is not currently architecturally valid */ > > ksft_test_result(arch, "%s_arch_set\n", type_name); > > } else { > > - ksft_test_result_skip("%s_arch_set\n"); > > + ksft_test_result_skip("%s_arch_set\n", type_name); > > } > > } > > Okay, I almost forgot that I had a patch fixing this as part of another series: > https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/ > If that is OK, Will, can you please pull that? Or should I send that as a > separate patch? I think Mark already suggested sending that separately: | This should ideally be a separate patch, there's no overlap. and he's right: it's best to keep fixes and features separate. Will