From: Abhishek Tamboli <abhishektamboli9@gmail.com>
To: jic23@kernel.org
Cc: lars@metafoo.de, andriy.shevchenko@linux.intel.com,
biju.das.jz@bp.renesas.com, nuno.sa@analog.com,
skhan@linuxfoundation.org, rbmarliere@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: accel: bma180: Fix dataready interrupt to use INT2 pin
Date: Mon, 5 Aug 2024 23:02:37 +0530 [thread overview]
Message-ID: <20240805173237.475797-1-abhishektamboli9@gmail.com> (raw)
Update the interrupt configuration to use the INT2 pin for
the dataready interrupt.
Address the FIXME: support using the INT2 pin.
Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
drivers/iio/accel/bma180.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index 6581772cb0c4..d44409afffbf 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -126,7 +126,7 @@ struct bma180_part_info {
#define BMA250_SUSPEND_MASK BIT(7) /* chip will sleep */
#define BMA250_LOWPOWER_MASK BIT(6)
#define BMA250_DATA_INTEN_MASK BIT(4)
-#define BMA250_INT1_DATA_MASK BIT(0)
+#define BMA250_INT2_DATA_MASK BIT(7)
#define BMA250_INT_RESET_MASK BIT(7) /* Reset pending interrupts */
struct bma180_data {
@@ -425,10 +425,9 @@ static int bma250_chip_config(struct bma180_data *data)
if (ret)
goto err;
/*
- * This enables dataready interrupt on the INT1 pin
- * FIXME: support using the INT2 pin
+ * This enables dataready interrupt on the INT2 pin
*/
- ret = bma180_set_bits(data, BMA250_INT_MAP_REG, BMA250_INT1_DATA_MASK, 1);
+ ret = bma180_set_bits(data, BMA250_INT_MAP_REG, BMA250_INT2_DATA_MASK, 1);
if (ret)
goto err;
--
2.34.1
next reply other threads:[~2024-08-05 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 17:32 Abhishek Tamboli [this message]
2024-08-06 16:32 ` [PATCH] iio: accel: bma180: Fix dataready interrupt to use INT2 pin Jonathan Cameron
2024-08-06 17:46 ` Abhishek Tamboli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805173237.475797-1-abhishektamboli9@gmail.com \
--to=abhishektamboli9@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rbmarliere@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox