[PATCH v4 3/3] kdb: Remove fallback interpretation of arbitrary numbers as hex

Nir Lichtman
2024-10-28T19:22:30Z

Remove logic that enables a fallback of interpreting numbers supplied in KDB CLI
to be interpreted as hex without explicit "0x" prefix as this can be confusing
for the end users.

Suggested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Nir Lichtman <nir@lichtman.org>
---
kernel/debug/kdb/kdb_main.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index f8703ab760d9..5f4be507d79f 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -402,23 +402,15 @@ static void kdb_printenv(void)
*/
int kdbgetularg(const char *arg, unsigned long *value)
{
- /*
- * If the first fails, also try base 16, for us
- * folks too lazy to type the leading 0x...
- */
- if (kstrtoul(arg, 0, value)) {
- if (kstrtoul(arg, 16, value))
- return KDB_BADINT;
- }
+ if (kstrtoul(arg, 0, value))
+ return KDB_BADINT;
return 0;
}

int kdbgetu64arg(const char *arg, u64 *value)
{
- if (kstrtou64(arg, 0, value)) {
- if (kstrtou64(arg, 16, value))
- return KDB_BADINT;
- }
+ if (kstrtou64(arg, 0, value))
+ return KDB_BADINT;
return 0;
}

--
2.39.2