Re: [PATCH v4 0/3] Replace the use of simple_strtol/ul functions with kstrto

Nir Lichtman
2024-11-08T11:06:41Z

On Fri, Nov 08, 2024 at 08:38:35AM +0000, Daniel Thompson wrote:
>
> On Mon, 28 Oct 2024 19:17:00 +0000, Nir Lichtman wrote:
> > The simple_str* family of functions perform no error checking in
> > scenarios where the input value overflows the intended output variable.
> > This results in these function successfully returning even when the
> > output does not match the input string.
> >
> > Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
> > simple_strtoul(), and simple_strtoull() functions explicitly ignore
> > overflows, which may lead to unexpected results in callers."
> > Hence, the use of those functions is discouraged.
> >
> > [...]
>
> Applied, thanks!

Thanks!

Nir