Re: [PATCH 1/2] Documentation: dt-bindings: Fix repeated words

Rob Herring
2024-11-07T16:04:55Z

On Wed, Nov 06, 2024 at 11:11:23PM -0700, Abhinav Saxena wrote:
> Fix unintentional word repetitions in devicetree binding documentation:
> - usb.txt: Fix repeated "two"
> - mvebu-devbus.txt: Fix repeated "from"
> - gpio.txt: Fix repeated "Both"
> - pinctrl-bindings.txt: Fix repeated "device"
> - cavium/bootbus.txt: Fix repeated "one"
>
> These issues were identified using the checkpatch.pl script.
>
> Signed-off-by: Abhinav Saxena <xandfury@gmail.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio.txt | 2 +-

This and...

> .../devicetree/bindings/memory-controllers/mvebu-devbus.txt | 2 +-
> Documentation/devicetree/bindings/mips/cavium/bootbus.txt | 2 +-
> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 2 +-

...this I'll take. The others need to be converted to schema.

> Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txt | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt
> index d82c32217fff..530420475a4f 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> @@ -304,7 +304,7 @@ pins 50..69.
> It is also possible to use pin groups for gpio ranges when pin groups are the
> easiest and most convenient mapping.
>
> -Both both <pinctrl-base> and <count> must set to 0 when using named pin groups
> +Both <pinctrl-base> and <count> must set to 0 when using named pin groups
> names.
>
> The property gpio-ranges-group-names must contain exactly one string for each
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mvebu-devbus.txt b/Documentation/devicetree/bindings/memory-controllers/mvebu-devbus.txt
> index 8b9388cc1ccc..1983d7eabd2b 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mvebu-devbus.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/mvebu-devbus.txt
> @@ -43,7 +43,7 @@ Read parameters:
> - devbus,bus-width: Defines the bus width, in bits (e.g. <16>).
> Mandatory, except if devbus,keep-config is used.
>
> - - devbus,badr-skew-ps: Defines the time delay from from A[2:0] toggle,
> + - devbus,badr-skew-ps: Defines the time delay from A[2:0] toggle,
> to read data sample. This parameter is useful for
> synchronous pipelined devices, where the address
> precedes the read data by one or two cycles.
> diff --git a/Documentation/devicetree/bindings/mips/cavium/bootbus.txt b/Documentation/devicetree/bindings/mips/cavium/bootbus.txt
> index 6581478225a2..1bc655d285ce 100644
> --- a/Documentation/devicetree/bindings/mips/cavium/bootbus.txt
> +++ b/Documentation/devicetree/bindings/mips/cavium/bootbus.txt
> @@ -15,7 +15,7 @@ Properties:
>
> - #size-cells: Must be <1>.
>
> -- ranges: There must be one one triplet of (child-bus-address,
> +- ranges: There must be one triplet of (child-bus-address,
> parent-bus-address, length) for each active chip select. If the
> length element for any triplet is zero, the chip select is disabled,
> making it inactive.
> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> index 6904072d3944..500b76ba2ab3 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> @@ -18,7 +18,7 @@ states. The number and names of those states is defined by the client device's
> own binding.
>
> The common pinctrl bindings defined in this file provide an infrastructure
> -for client device device tree nodes to map those state names to the pin
> +for client device tree nodes to map those state names to the pin

Actually I think this was correct. See "client device" used above.
Maybe "client device Devicetree nodes" would be a bit clearer and use
the right form of Devicetree.

Rob