From: Greg KH <gregkh@linuxfoundation.org>
To: Marvin Murithi <murithimarvin09@gmail.com>
Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
Marvin Murithi <50557936+rimubytes@users.noreply.github.com>
Subject: Re: [PATCH] selftests: Fix spelling mistake in documentation
Date: Tue, 18 Feb 2025 08:40:19 +0100 [thread overview]
Message-ID: <2025021827-partner-trekker-0025@gregkh> (raw)
In-Reply-To: <20250218072849.23752-1-murithimarvin09@gmail.com>
On Tue, Feb 18, 2025 at 07:28:49AM +0000, Marvin Murithi wrote:
> From: Marvin Murithi <50557936+rimubytes@users.noreply.github.com>
>
> ---
> tools/testing/selftests/net/netfilter/conntrack_icmp_related.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/netfilter/conntrack_icmp_related.sh b/tools/testing/selftests/net/netfilter/conntrack_icmp_related.sh
> index c63d840ead61..f63b7f12b36a 100755
> --- a/tools/testing/selftests/net/netfilter/conntrack_icmp_related.sh
> +++ b/tools/testing/selftests/net/netfilter/conntrack_icmp_related.sh
> @@ -171,7 +171,7 @@ table inet filter {
> }
> EOF
>
> -# make sure NAT core rewrites adress of icmp error if nat is used according to
> +# make sure NAT core rewrites address of icmp error if nat is used according to
> # conntrack nat information (icmp error will be directed at nsrouter1 address,
> # but it needs to be routed to nsclient1 address).
> ip netns exec "$nsrouter1" nft -f - <<EOF
> --
> 2.47.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch does not have a Signed-off-by: line. Please read the
kernel file, Documentation/process/submitting-patches.rst and resend
it after adding that line. Note, the line needs to be in the body of
the email, before the patch, not at the bottom of the patch or in the
email signature.
- You sent multiple patches, yet no indication of which ones should be
applied in which order.
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg,
and everyone else, to know what this patch is all about. Please read
the section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what a proper
Subject: line should look like.
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2025-02-18 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 7:28 [PATCH] selftests: Fix spelling mistake in documentation Marvin Murithi
2025-02-18 7:40 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-18 7:20 Marvin Murithi
2025-02-18 7:17 Marvin Murithi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021827-partner-trekker-0025@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=50557936+rimubytes@users.noreply.github.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=murithimarvin09@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox