public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Cc: lars@metafoo.de, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com,
	skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
	marcelo.schmitt1@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] iio: adis16201: Correct inclinometer channel resolution
Date: Mon, 21 Apr 2025 14:59:31 +0100	[thread overview]
Message-ID: <20250421145931.605df588@jic23-huawei> (raw)
In-Reply-To: <20250421131539.912966-1-gshahrouzi@gmail.com>

On Mon, 21 Apr 2025 09:15:39 -0400
Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote:

> The inclinometer channels were previously defined with 14 realbits.
> However, the ADIS16201 datasheet states the resolution for these output
> channels is 12 bits (Page 14, text description; Page 15, table 7).
> 
> Correct the realbits value to 12 to accurately reflect the hardware.
> 
> Fixes: f7fe1d1dd5a5 ("staging: iio: new adis16201 driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com>
If you post a new version, always add the version number.

Anyhow, I was just asking for the fixes tag, but this is fine.

Applied to the fixes-togreg branch of iio.git

Thanks,

Jonathan

> ---
>  drivers/iio/accel/adis16201.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> index 982b33f6eccac..dcc8d9f2ee0f1 100644
> --- a/drivers/iio/accel/adis16201.c
> +++ b/drivers/iio/accel/adis16201.c
> @@ -211,9 +211,9 @@ static const struct iio_chan_spec adis16201_channels[] = {
>  			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
>  	ADIS_AUX_ADC_CHAN(ADIS16201_AUX_ADC_REG, ADIS16201_SCAN_AUX_ADC, 0, 12),
>  	ADIS_INCLI_CHAN(X, ADIS16201_XINCL_OUT_REG, ADIS16201_SCAN_INCLI_X,
> -			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> +			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12),
>  	ADIS_INCLI_CHAN(Y, ADIS16201_YINCL_OUT_REG, ADIS16201_SCAN_INCLI_Y,
> -			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
> +			BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 12),
>  	IIO_CHAN_SOFT_TIMESTAMP(7)
>  };
>  


  parent reply	other threads:[~2025-04-21 13:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-19 14:45 [PATCH] iio: adis16201: Correct inclinometer channel resolution Gabriel Shahrouzi
2025-04-19 17:31 ` Marcelo Schmitt
2025-04-21 11:49 ` Jonathan Cameron
2025-04-21 13:05   ` Gabriel Shahrouzi
2025-04-21 13:58     ` Jonathan Cameron
2025-04-21 13:15   ` Gabriel Shahrouzi
2025-04-21 13:50     ` Marcelo Schmitt
2025-04-21 13:55       ` Gabriel Shahrouzi
2025-04-21 14:08         ` Marcelo Schmitt
2025-04-21 14:16           ` Gabriel Shahrouzi
2025-04-21 14:10         ` Jonathan Cameron
2025-04-21 13:59     ` Jonathan Cameron [this message]
2025-04-21 14:20       ` Gabriel Shahrouzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250421145931.605df588@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=gshahrouzi@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt1@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox