From: Jonathan Cameron <jic23@kernel.org>
To: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Cc: gregkh@linuxfoundation.org, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, Michael.Hennerich@analog.com,
skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH v3 3/3] staging: iio: ad9832: Add minor improvements to ad9832_write_powerdown
Date: Fri, 25 Apr 2025 09:19:10 +0100 [thread overview]
Message-ID: <20250425091910.545bdce7@jic23-huawei> (raw)
In-Reply-To: <CAKUZ0zLgH9Ec5FMEjXa59-bBEVooEQUOeGuZ9OJw=A3P3OWp5A@mail.gmail.com>
On Thu, 24 Apr 2025 18:29:57 -0400
Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote:
> On Mon, Apr 21, 2025 at 7:40 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sun, 20 Apr 2025 13:54:19 -0400
> > Gabriel Shahrouzi <gshahrouzi@gmail.com> wrote:
> >
> > > Minimize size of type that needs to be used by replacing unsigned long
> > > with bool. Avoid redundancy by checking if cached power state is the
> > > same as the one requested.
> > >
Hi Garbiel,
Quick process comment given you are sending quite a few emails (which is great!)
Please don't bother replying to say you are doing something suggested.
Focus any reply (including cropping irrelevant context) on what you want to
discuss. If there is nothing to discuss your reply is effectively the change
log of the next version of the series.
Even a simple email like this one takes a little time for reviewers to look
at and they gain no extra information from doing so.
Thanks,
Jonathan
next prev parent reply other threads:[~2025-04-25 8:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 17:54 [PATCH v3 0/3] Fix and refactor output disable logic Gabriel Shahrouzi
2025-04-20 17:54 ` [PATCH v3 1/3] iio: frequency: Use SLEEP bit instead of RESET to disable output Gabriel Shahrouzi
2025-04-20 17:54 ` [PATCH v3 2/3] staging: iio: ad9832: Refactor powerdown control Gabriel Shahrouzi
2025-04-21 11:37 ` Jonathan Cameron
2025-04-24 22:25 ` Gabriel Shahrouzi
2025-04-25 8:16 ` Jonathan Cameron
2025-04-20 17:54 ` [PATCH v3 3/3] staging: iio: ad9832: Add minor improvements to ad9832_write_powerdown Gabriel Shahrouzi
2025-04-21 11:40 ` Jonathan Cameron
2025-04-24 22:29 ` Gabriel Shahrouzi
2025-04-25 8:19 ` Jonathan Cameron [this message]
2025-04-21 11:33 ` [PATCH v3 0/3] Fix and refactor output disable logic Jonathan Cameron
2025-04-21 13:56 ` Gabriel Shahrouzi
2025-04-22 10:09 ` Dan Carpenter
2025-04-22 16:15 ` Gabriel Shahrouzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425091910.545bdce7@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=gshahrouzi@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox