Re: [PATCH RESEND] drm/amd/display: adds kernel-doc comment for dc_stream_remove_writeback()

Alex Hung
2025-05-02T22:25:34Z

Hi James,

checkpatch reports the following warning and error

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#18:
Adds a kernel-doc for externally linked dc_stream_remove_writeback()
function.

ERROR: trailing whitespace
#39: FILE: drivers/gpu/drm/amd/display/dc/core/dc_stream.c:561:
+ * Return: returns true on success, false otherwise. $

total: 1 errors, 1 warnings, 14 lines checked

On 4/30/25 23:56, James Flowers wrote:
> Adds a kernel-doc for externally linked dc_stream_remove_writeback() function.
>
> Signed-off-by: James Flowers <bold.zone2373@fastmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> index 0478dd856d8c..060ee6c3fc2e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
> @@ -552,6 +552,14 @@ bool dc_stream_fc_disable_writeback(struct dc *dc,
> return true;
> }
>
> +/**
> + * dc_stream_remove_writeback() - Disables writeback and removes writeback info.
> + * @dc: Display core control structure.
> + * @stream: Display core stream state.
> + * @dwb_pipe_inst: Display writeback pipe.
> + *
> + * Return: returns true on success, false otherwise.
> + */
> bool dc_stream_remove_writeback(struct dc *dc,
> struct dc_stream_state *stream,
> uint32_t dwb_pipe_inst)