Re: [PATCH 2/4] docs: Improve grammar, formatting in Video4Linux

Hanne-Lotta Mäenpää
2025-05-21T15:17:40Z

Hello,

On 5/19/25 04:23, Bagas Sanjaya wrote:
> On Sun, May 18, 2025 at 02:08:04AM -0600, Jonathan Corbet wrote:
>>> description of the correct character encoding for Programme Service
>>> name strings. Also from RDS specification, PS is usually a single
>>> eight character text. However, it is also possible to find receivers
>>> - which can scroll strings sized as 8 x N characters. So, this control
>>> + which can scroll strings sized as 8 x N characters. Therefore this control
>>
>> This kind of change just seems like churn that isn't really improving
>> the content?
>
> I prefer the original as both so and therefore have the same meaning.>
>>> ``V4L2_CID_RDS_TX_ALT_FREQS (__u32 array)``
>>> The alternate frequencies in kHz units. The RDS standard allows for
>>> - up to 25 frequencies to be defined. Drivers may support fewer
>>> - frequencies so check the array size.
>>> + up to 25 frequencies to be defined. Because drivers may support fewer
>>> + frequencies, check the array size.
>>
>> Here too, I'm not sure I see the value in this kind of change.
>
> Again I'm agree.
>
> Thanks.
>

Alright, that is two opinions in favor of not changing this. I can send
a version 2 of this patch series without these.

Thank you for reviewing!

Best regards,

Hanne-Lotta Mäenpää