From: Greg KH <gregkh@linuxfoundation.org>
To: Brahmajit Das <listout@listout.xyz>
Cc: stable@kernel.org, patches@lists.linux.dev,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
mpatocka@redhat.com, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] dm-verity: fix a memory leak if some arguments are specified multiple times
Date: Fri, 6 Jun 2025 08:02:39 +0200 [thread overview]
Message-ID: <2025060617-battalion-halved-04eb@gregkh> (raw)
In-Reply-To: <20250605201116.24492-1-listout@listout.xyz>
On Fri, Jun 06, 2025 at 01:41:16AM +0530, Brahmajit Das wrote:
> From: Mikulas Patocka <mpatocka@redhat.com>
>
> From: Mikulas Patocka <mpatocka@redhat.com>
Twice is not good :(
>
> [ Upstream commit 66be40a14e496689e1f0add50118408e22c96169 ]
>
> If some of the arguments "check_at_most_once", "ignore_zero_blocks",
> "use_fec_from_device", "root_hash_sig_key_desc" were specified more than
> once on the target line, a memory leak would happen.
>
> This commit fixes the memory leak. It also fixes error handling in
> verity_verify_sig_parse_opt_args.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Brahmajit Das <listout@listout.xyz>
> ---
> drivers/md/dm-verity-fec.c | 4 ++++
> drivers/md/dm-verity-target.c | 8 +++++++-
> drivers/md/dm-verity-verify-sig.c | 17 +++++++++++++----
> 3 files changed, 24 insertions(+), 5 deletions(-)
What kernel tree(s) is this for?
thanks,
greg k-h
prev parent reply other threads:[~2025-06-06 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 20:11 [PATCH 1/1] dm-verity: fix a memory leak if some arguments are specified multiple times Brahmajit Das
2025-06-05 20:30 ` Brahmajit Das
2025-06-06 6:04 ` Greg KH
2025-06-06 9:07 ` Brahmajit Das
2025-06-06 6:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025060617-battalion-halved-04eb@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=listout@listout.xyz \
--cc=mpatocka@redhat.com \
--cc=patches@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox