From: Pranav Tyagi <pranav.tyagi03@gmail.com>
To: aahringo@redhat.com, teigland@redhat.com
Cc: skhan@linuxfoundation.org, gfs2@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Pranav Tyagi <pranav.tyagi03@gmail.com>
Subject: [PATCH] fs/dlm: use scnprintf() in lockspace show funcs
Date: Mon, 16 Jun 2025 16:04:41 +0530 [thread overview]
Message-ID: <20250616103441.370330-1-pranav.tyagi03@gmail.com> (raw)
Replace all snprintf() instances with scnprintf(). snprintf() returns
the number of bytes that would have been written had there been enough
space. For sysfs attributes, snprintf() should not be used for the
show() method. Instead use scnprintf() which returns the number of
bytes actually written.
Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
fs/dlm/config.c | 2 +-
fs/dlm/lockspace.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/dlm/config.c b/fs/dlm/config.c
index a23fd524a6ee..10486a46a540 100644
--- a/fs/dlm/config.c
+++ b/fs/dlm/config.c
@@ -185,7 +185,7 @@ static ssize_t cluster_##name##_store(struct config_item *item, \
} \
static ssize_t cluster_##name##_show(struct config_item *item, char *buf) \
{ \
- return snprintf(buf, PAGE_SIZE, "%u\n", dlm_config.ci_##name); \
+ return scnprintf(buf, PAGE_SIZE, "%u\n", dlm_config.ci_##name); \
} \
CONFIGFS_ATTR(cluster_, name);
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c
index 1929327ffbe1..2e83e381e54c 100644
--- a/fs/dlm/lockspace.c
+++ b/fs/dlm/lockspace.c
@@ -69,7 +69,7 @@ static ssize_t dlm_event_store(struct dlm_ls *ls, const char *buf, size_t len)
static ssize_t dlm_id_show(struct dlm_ls *ls, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%u\n", ls->ls_global_id);
+ return scnprintf(buf, PAGE_SIZE, "%u\n", ls->ls_global_id);
}
static ssize_t dlm_id_store(struct dlm_ls *ls, const char *buf, size_t len)
@@ -83,7 +83,7 @@ static ssize_t dlm_id_store(struct dlm_ls *ls, const char *buf, size_t len)
static ssize_t dlm_nodir_show(struct dlm_ls *ls, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%u\n", dlm_no_directory(ls));
+ return scnprintf(buf, PAGE_SIZE, "%u\n", dlm_no_directory(ls));
}
static ssize_t dlm_nodir_store(struct dlm_ls *ls, const char *buf, size_t len)
@@ -101,12 +101,12 @@ static ssize_t dlm_nodir_store(struct dlm_ls *ls, const char *buf, size_t len)
static ssize_t dlm_recover_status_show(struct dlm_ls *ls, char *buf)
{
uint32_t status = dlm_recover_status(ls);
- return snprintf(buf, PAGE_SIZE, "%x\n", status);
+ return scnprintf(buf, PAGE_SIZE, "%x\n", status);
}
static ssize_t dlm_recover_nodeid_show(struct dlm_ls *ls, char *buf)
{
- return snprintf(buf, PAGE_SIZE, "%d\n", ls->ls_recover_nodeid);
+ return scnprintf(buf, PAGE_SIZE, "%d\n", ls->ls_recover_nodeid);
}
struct dlm_attr {
--
2.49.0
next reply other threads:[~2025-06-16 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 10:34 Pranav Tyagi [this message]
2025-06-16 14:22 ` [PATCH] fs/dlm: use scnprintf() in lockspace show funcs Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250616103441.370330-1-pranav.tyagi03@gmail.com \
--to=pranav.tyagi03@gmail.com \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox