public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Pranav Tyagi <pranav.tyagi03@gmail.com>
To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com
Cc: skhan@linuxfoundation.org, ocfs2-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev,
	Pranav Tyagi <pranav.tyagi03@gmail.com>
Subject: [PATCH] fs/ocfs2: use scnprintf() in show functions
Date: Mon, 16 Jun 2025 16:20:28 +0530	[thread overview]
Message-ID: <20250616105028.371633-1-pranav.tyagi03@gmail.com> (raw)

Replace all snprintf() instances with scnprintf(). snprintf() returns
the number of bytes that would have been written had there been enough
space. For sysfs attributes, snprintf() should not be used for the
show() method. Instead use scnprintf() which returns the number of bytes
actually written.

Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
 fs/ocfs2/cluster/masklog.c |  2 +-
 fs/ocfs2/cluster/sys.c     |  2 +-
 fs/ocfs2/stackglue.c       | 14 +++++++-------
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/ocfs2/cluster/masklog.c b/fs/ocfs2/cluster/masklog.c
index 563881ddbf00..0bc21dc71d29 100644
--- a/fs/ocfs2/cluster/masklog.c
+++ b/fs/ocfs2/cluster/masklog.c
@@ -28,7 +28,7 @@ static ssize_t mlog_mask_show(u64 mask, char *buf)
 	else
 		state = "off";
 
-	return snprintf(buf, PAGE_SIZE, "%s\n", state);
+	return scnprintf(buf, PAGE_SIZE, "%s\n", state);
 }
 
 static ssize_t mlog_mask_store(u64 mask, const char *buf, size_t count)
diff --git a/fs/ocfs2/cluster/sys.c b/fs/ocfs2/cluster/sys.c
index 022f716c74ff..23febbe3dc5d 100644
--- a/fs/ocfs2/cluster/sys.c
+++ b/fs/ocfs2/cluster/sys.c
@@ -21,7 +21,7 @@
 static ssize_t version_show(struct kobject *kobj, struct kobj_attribute *attr,
 			    char *buf)
 {
-	return snprintf(buf, PAGE_SIZE, "%u\n", O2NM_API_VERSION);
+	return scnprintf(buf, PAGE_SIZE, "%u\n", O2NM_API_VERSION);
 }
 static struct kobj_attribute attr_version =
 	__ATTR(interface_revision, S_IRUGO, version_show, NULL);
diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
index a28c127b9934..9af03869a04b 100644
--- a/fs/ocfs2/stackglue.c
+++ b/fs/ocfs2/stackglue.c
@@ -477,9 +477,9 @@ static ssize_t ocfs2_max_locking_protocol_show(struct kobject *kobj,
 
 	spin_lock(&ocfs2_stack_lock);
 	if (locking_max_version.pv_major)
-		ret = snprintf(buf, PAGE_SIZE, "%u.%u\n",
-			       locking_max_version.pv_major,
-			       locking_max_version.pv_minor);
+		ret = scnprintf(buf, PAGE_SIZE, "%u.%u\n",
+				locking_max_version.pv_major,
+				locking_max_version.pv_minor);
 	spin_unlock(&ocfs2_stack_lock);
 
 	return ret;
@@ -525,8 +525,8 @@ static ssize_t ocfs2_active_cluster_plugin_show(struct kobject *kobj,
 
 	spin_lock(&ocfs2_stack_lock);
 	if (active_stack) {
-		ret = snprintf(buf, PAGE_SIZE, "%s\n",
-			       active_stack->sp_name);
+		ret = scnprintf(buf, PAGE_SIZE, "%s\n",
+				active_stack->sp_name);
 		if (ret >= PAGE_SIZE)
 			ret = -E2BIG;
 	}
@@ -545,7 +545,7 @@ static ssize_t ocfs2_cluster_stack_show(struct kobject *kobj,
 {
 	ssize_t ret;
 	spin_lock(&ocfs2_stack_lock);
-	ret = snprintf(buf, PAGE_SIZE, "%s\n", cluster_stack_name);
+	ret = scnprintf(buf, PAGE_SIZE, "%s\n", cluster_stack_name);
 	spin_unlock(&ocfs2_stack_lock);
 
 	return ret;
@@ -595,7 +595,7 @@ static ssize_t ocfs2_dlm_recover_show(struct kobject *kobj,
 					struct kobj_attribute *attr,
 					char *buf)
 {
-	return snprintf(buf, PAGE_SIZE, "1\n");
+	return scnprintf(buf, PAGE_SIZE, "1\n");
 }
 
 static struct kobj_attribute ocfs2_attr_dlm_recover_support =
-- 
2.49.0


             reply	other threads:[~2025-06-16 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 10:50 Pranav Tyagi [this message]
2025-06-16 14:21 ` [PATCH] fs/ocfs2: use scnprintf() in show functions Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616105028.371633-1-pranav.tyagi03@gmail.com \
    --to=pranav.tyagi03@gmail.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox