From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0556B2980DA; Fri, 27 Jun 2025 10:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751018810; cv=none; b=LsckRKsiB/Phc2nVJ/p6Yv46LzW16WB/DPVhHLRNpz6fKzQrjIzgP+nif5Zs9PVOh/8M5NIYoELRYWjsg71E4HPSsqUERickNt2WLIxaS1HhoQpOq15FJrvQ3+YUSUF5P5CAd1q5jaAWWlHi/cGDyKIanL5pT1iyiqOPQB+4LRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751018810; c=relaxed/simple; bh=r0YnwAalgTRGHMtfmaMXLEDkTNOEImu3iRSewaoDnpk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=MbWuXKlQP4fvWco1jeZAIdMa21k+RdNs7z6M+EJzq1r22PvMLx5aDnvNJMoX3tk207nMCkZNLJ0Ar2LvFab9J7qu3YOGGvLHOFObHDagJoow3+qonrJouxLeNfvx+KgZRteiMH7raiR2dasprje+xT2lXVmNTJ1WpMedXuxkV4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZPfDGr7U; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZPfDGr7U" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a4e62619afso228002f8f.1; Fri, 27 Jun 2025 03:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751018807; x=1751623607; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JxXlLI+5RHgcRNLRoMQn0tLo5umStcod1M6mXH84eyE=; b=ZPfDGr7UJbSd7UiBt6mHp3eP9nwfhbSaj2XfsCpqkzQxx0oTvOcBY39irMqKBFHuER KhCL2/NIzf5updDVYaAjK1ZwlU34LXftNEfPoVxJqZTNjViGwxjW8pVTtEvEv9Hi1Tls d1fwELv/tY3N9TROEeJi9Mja0GqJP6LrW9BJA99y0iUr/iG7QmMPbzwMAWl1nF0lfOtg pjc0s0JPtNPL7png9KfvEnTMhh0FNz15xvYQXlHeUziGL4duJHjA8H7ym/z4NYU+zaCO EUy8sPIS9G6JWAB812je24+HOO+QYDchshElgR6e7OCND0eBZChA/C2XJTFFgsgwjCQt uIuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751018807; x=1751623607; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JxXlLI+5RHgcRNLRoMQn0tLo5umStcod1M6mXH84eyE=; b=mOOc4/bEymRA+fwS1gjfLzDsrVB14rGNcV5NXuCVlUU5WL08Iavsbej+Ocn8DCVynV nSlT0d2+HLuzAfPsNtmc/2NYAGGBA5oURdZSxPb/14WW1tTlCf3XcOyn2QBFAYycPHrx dfTlldrSSj3ZlT2SZ7MIexNm6N1IGcRwzO9E64/PqAW9fpZU1NhDMHgo78oCfKHSuw+e B9K+adr5IlR6Kj7K7ZrYYgfG+XhlHqXuCstQYFlnNwbgHLozxlq454ccLVDwYDf+q1jG TAtT3TqbWv3A+WEBdwruDFhcj5Qp9+Lf9OIEuMiIFY5YRuiF770HclqNgGhJh/vOn5Sy a8nw== X-Forwarded-Encrypted: i=1; AJvYcCUtbT6hMSbl+8T8aaCvRF/zM36ZVyksP1sXJXQmLkEyZhyNkfpuj/i0JI5ttiBI8aXtdXWxpwm2cVYicEOf@lists.linux.dev X-Gm-Message-State: AOJu0YwJclaDH1XUUQws793u25NDqhosBoztrufMtgf8UIfLZ5mXCeWK U2oYhf3uxLHAzCfbEsgXLEbcFcX8gq9tXguRNSpgTXwlqUQx6fINz+kd X-Gm-Gg: ASbGncvvHCkuFo9PNwdYUo+o05jcydiByK7Pp5+3gClqeURWFTBYVStTeG8TxI2biNp 1qP0txCphltlStRhovZpIeEtmcq23kbAuuy32GJbAk2AfCc33X9NngJHcppJKL3PKJb/VmIcpsF qrkhaYBJlmfiYJ0DMemU/Tg3G7Rh7ls6oRvMT76tOXojlekIXugCq1R9V0W53PV4ajytfWbG9tM 9CYlAU+zYSLomsduGy4NEgTUOAHcPm2S2BcXkkHk7sEdZYPvjilS+E0jYz5N92XdZyUpv/+C1kG m1EhcagHKjRkZn2iN8lzQPRvOSdDPJUp5uzCiCJfVtYdaX3SMDz7bGt+hyRjdzbuIUJOO+wTe2z xXIVCC8Lpvm/cFCLLc33Dt78v X-Google-Smtp-Source: AGHT+IGPWENIh37fy0usHQ/GxRQDWqrtNlHrDfI+wS47KXWgE9P6pSxGpvKCA6RJwezPYbisfZU3uw== X-Received: by 2002:a05:600c:358d:b0:453:8c5:95d3 with SMTP id 5b1f17b1804b1-4538ee5d303mr10792245e9.7.1751018806659; Fri, 27 Jun 2025 03:06:46 -0700 (PDT) Received: from localhost.localdomain ([156.208.147.213]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm75908545e9.5.2025.06.27.03.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jun 2025 03:06:46 -0700 (PDT) From: Abdelrahman Fekry To: andy@kernel.org, hdegoede@redhat.com, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-kernel-mentees@lists.linux.dev, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, skhan@linuxfoundation.com, dan.carpenter@linaro.org, Abdelrahman Fekry , Hans de Goede Subject: [PATCH v5] staging: media: atomisp: remove debug sysfs attributes active_bo and free_bo Date: Fri, 27 Jun 2025 13:06:04 +0300 Message-Id: <20250627100604.29061-1-abdelrahmanfekry375@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sysfs attributes active_bo and free_bo expose internal buffer state used only for debugging purposes. These are not part of any standard kernel ABI, and need to be removed before this driver may be moved out of drivers/staging. - Remove active_bo and free_bo attributes - Remove group registration calls form hmm_init() and hmm_cleanup() Suggested-by: Hans de Goede Signed-off-by: Abdelrahman Fekry --- v5: - remove stray change v4: https://lore.kernel.org/all/20250627072939.21447-1-abdelrahmanfekry375@gmail.com/ - fix typos v3: https://lore.kernel.org/all/20250624170746.47188-1-abdelrahmanfekry375@gmail.com/ - remove blank line v2: https://lore.kernel.org/all/20250624144943.39297-1-abdelrahmanfekry375@gmail.com/ - add Suggested-by line - remove unnecessary comments v1: https://lore.kernel.org/all/20250624130841.34693-1-abdelrahmanfekry375@gmail.com/ --- drivers/staging/media/atomisp/pci/hmm/hmm.c | 91 --------------------- 1 file changed, 91 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/media/atomisp/pci/hmm/hmm.c index 84102c3aaf97..f998b57f90c4 100644 --- a/drivers/staging/media/atomisp/pci/hmm/hmm.c +++ b/drivers/staging/media/atomisp/pci/hmm/hmm.c @@ -28,88 +28,6 @@ struct hmm_bo_device bo_device; static ia_css_ptr dummy_ptr = mmgr_EXCEPTION; static bool hmm_initialized; -/* - * p: private - * v: vmalloc - */ -static const char hmm_bo_type_string[] = "pv"; - -static ssize_t bo_show(struct device *dev, struct device_attribute *attr, - char *buf, struct list_head *bo_list, bool active) -{ - ssize_t ret = 0; - struct hmm_buffer_object *bo; - unsigned long flags; - int i; - long total[HMM_BO_LAST] = { 0 }; - long count[HMM_BO_LAST] = { 0 }; - int index1 = 0; - int index2 = 0; - - ret = scnprintf(buf, PAGE_SIZE, "type pgnr\n"); - if (ret <= 0) - return 0; - - index1 += ret; - - spin_lock_irqsave(&bo_device.list_lock, flags); - list_for_each_entry(bo, bo_list, list) { - if ((active && (bo->status & HMM_BO_ALLOCED)) || - (!active && !(bo->status & HMM_BO_ALLOCED))) { - ret = scnprintf(buf + index1, PAGE_SIZE - index1, - "%c %d\n", - hmm_bo_type_string[bo->type], bo->pgnr); - - total[bo->type] += bo->pgnr; - count[bo->type]++; - if (ret > 0) - index1 += ret; - } - } - spin_unlock_irqrestore(&bo_device.list_lock, flags); - - for (i = 0; i < HMM_BO_LAST; i++) { - if (count[i]) { - ret = scnprintf(buf + index1 + index2, - PAGE_SIZE - index1 - index2, - "%ld %c buffer objects: %ld KB\n", - count[i], hmm_bo_type_string[i], - total[i] * 4); - if (ret > 0) - index2 += ret; - } - } - - /* Add trailing zero, not included by scnprintf */ - return index1 + index2 + 1; -} - -static ssize_t active_bo_show(struct device *dev, struct device_attribute *attr, - char *buf) -{ - return bo_show(dev, attr, buf, &bo_device.entire_bo_list, true); -} - -static ssize_t free_bo_show(struct device *dev, struct device_attribute *attr, - char *buf) -{ - return bo_show(dev, attr, buf, &bo_device.entire_bo_list, false); -} - - -static DEVICE_ATTR_RO(active_bo); -static DEVICE_ATTR_RO(free_bo); - -static struct attribute *sysfs_attrs_ctrl[] = { - &dev_attr_active_bo.attr, - &dev_attr_free_bo.attr, - NULL -}; - -static struct attribute_group atomisp_attribute_group[] = { - {.attrs = sysfs_attrs_ctrl }, -}; - int hmm_init(void) { int ret; @@ -130,14 +48,6 @@ int hmm_init(void) */ dummy_ptr = hmm_alloc(1); - if (!ret) { - ret = sysfs_create_group(&atomisp_dev->kobj, - atomisp_attribute_group); - if (ret) - dev_err(atomisp_dev, - "%s Failed to create sysfs\n", __func__); - } - return ret; } @@ -145,7 +55,6 @@ void hmm_cleanup(void) { if (dummy_ptr == mmgr_EXCEPTION) return; - sysfs_remove_group(&atomisp_dev->kobj, atomisp_attribute_group); /* free dummy memory first */ hmm_free(dummy_ptr); -- 2.25.1