From: Greg KH <gregkh@linuxfoundation.org>
To: Pranav Tyagi <pranav.tyagi03@gmail.com>
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
pvmohammedanees2003@gmail.com, akpm@linux-foundation.org,
sashal@kernel.org, skhan@linuxfoundation.org,
stable@vger.kernel.org, linux-kernel-mentees@lists.linux.dev,
syzbot+e0055ea09f1f5e6fabdd@syzkaller.appspotmail.com,
Junxiao Bi <junxiao.bi@oracle.com>,
Changwei Ge <gechangwei@live.cn>, Gang He <ghe@suse.com>,
Jun Piao <piaojun@huawei.com>
Subject: Re: [PATCH 5.15.y] ocfs2: fix deadlock in ocfs2_get_system_file_inode
Date: Sat, 12 Jul 2025 15:46:00 +0200 [thread overview]
Message-ID: <2025071245-snowsuit-pension-061d@gregkh> (raw)
In-Reply-To: <20250630083542.10121-1-pranav.tyagi03@gmail.com>
On Mon, Jun 30, 2025 at 02:05:42PM +0530, Pranav Tyagi wrote:
> From: Mohammed Anees <pvmohammedanees2003@gmail.com>
>
> [ Upstream commit 7bf1823e010e8db2fb649c790bd1b449a75f52d8 ]
>
> syzbot has found a possible deadlock in ocfs2_get_system_file_inode [1].
>
> The scenario is depicted here,
>
> CPU0 CPU1
> lock(&ocfs2_file_ip_alloc_sem_key);
> lock(&osb->system_file_mutex);
> lock(&ocfs2_file_ip_alloc_sem_key);
> lock(&osb->system_file_mutex);
>
> The function calls which could lead to this are:
>
> CPU0
> ocfs2_mknod - lock(&ocfs2_file_ip_alloc_sem_key);
> .
> .
> .
> ocfs2_get_system_file_inode - lock(&osb->system_file_mutex);
>
> CPU1 -
> ocfs2_fill_super - lock(&osb->system_file_mutex);
> .
> .
> .
> ocfs2_read_virt_blocks - lock(&ocfs2_file_ip_alloc_sem_key);
>
> This issue can be resolved by making the down_read -> down_read_try
> in the ocfs2_read_virt_blocks.
>
> [1] https://syzkaller.appspot.com/bug?extid=e0055ea09f1f5e6fabdd
>
> [ Backport to 5.15: context cleanly applied with no semantic changes.
> Build-tested. ]
We can't take a 5.15.y version, without it being in 6.1.y first, sorry
:(
next prev parent reply other threads:[~2025-07-12 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 8:35 [PATCH 5.15.y] ocfs2: fix deadlock in ocfs2_get_system_file_inode Pranav Tyagi
2025-07-12 13:46 ` Greg KH [this message]
2025-07-12 17:11 ` Pranav Tyagi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071245-snowsuit-pension-061d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=gechangwei@live.cn \
--cc=ghe@suse.com \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=piaojun@huawei.com \
--cc=pranav.tyagi03@gmail.com \
--cc=pvmohammedanees2003@gmail.com \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+e0055ea09f1f5e6fabdd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox