public inbox for linux-kernel-mentees@lists.linux-foundation.org
 help / color / mirror / Atom feed
From: Brigham Campbell <me@brighamcampbell.com>
To: dianders@chromium.org, tejasvipin76@gmail.com,
	diogo.ivo@tecnico.ulisboa.pt, skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linux.dev,
	dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Brigham Campbell <me@brighamcampbell.com>
Subject: [PATCH v6 0/4] drm: Fix bug in panel driver, update MIPI support macros
Date: Mon, 21 Jul 2025 19:53:07 -0600	[thread overview]
Message-ID: <20250722015313.561966-1-me@brighamcampbell.com> (raw)

This series removes the unintuitive mipi_dsi_generic_write_seq() macro
and related mipi_dsi_generic_write_chatty() method from the drm
subsystem. This is in accordance with a TODO item from Douglas Anderson
in the drm subsystem documentation. Tejas Vipin (among others) has
largely spearheaded this effort up until now, converting MIPI panel
drivers one at a time.

The second patch of the series removes the last remaining references to
mipi_dsi_generic_write_seq() in the jdi-lpm102a188a driver and updates
the driver to use the undeprecated _multi variants of MIPI functions. It
fixes a bug in the driver's unprepare function and cleans up duplicated
code using the new mipi_dsi_dual* macros introduced in the first patch.

changes to v6:
 - Fix various style and kerneldoc issues in patch 1/4
 - Fix typo mpi_dsi_dual... -> mipi_dsi_dual...
 - Fix incorrectly named "data" and "len" variables
 - Make _seq argument of mipi_dsi_dual_dcs_write_seq_multi macro
   variadic
 - Remove duplicate definition of mipi_dsi_dual_dcs_write_seq_multi
   macro from novatek display driver

changes to v5:
 - Rework mipi_dsi_dual to explicitly not support passing macros into
   _func and add "dual" variants of the generic and dcs write macros.
 - Make jdi-lpm102a188a use the new
   mipi_dsi_dual_generic_write_seq_multi macro.
 - Make local struct variable in jdi-lpm102a188a conform to reverse
   christmas tree order.

changes to v4:
 - Fix whitespace (I forgot to run checkpatch. Thanks for your patience
   as I familiarize myself with the kernel development process)
 - Initialize mipi_dsi_multi_context struct

changes to v3:
 - Define new mipi_dsi_dual macro in drm_mipi_dsi.h to reduce code
   duplication.
 - Fix bug in lpm102a188a panel driver's unprepare function which causes
   it to return a nonsensical value.
 - Make lpm102a188a panel driver's unprepare function send "display off"
   and "enter sleep mode" commands to both serial interfaces regardless
   of whether an error occurred when sending the last command.

changes to v2:
 - Remove all usages of deprecated MIPI functions from jdi-lpm102a188a
   driver instead of just mipi_dsi_generic_write_seq().
 - Update TODO item in drm documentation instead of removing it
   entirely.

Brigham Campbell (4):
  drm: Create mipi_dsi_dual* macros
  drm/panel: jdi-lpm102a188a: Fix bug and clean up driver
  drm: Remove unused MIPI write seq and chatty functions
  drm: docs: Update task from drm TODO list

 Documentation/gpu/todo.rst                    |  22 +-
 drivers/gpu/drm/drm_mipi_dsi.c                |  82 +-
 drivers/gpu/drm/panel/panel-jdi-lpm102a188a.c | 196 ++---
 drivers/gpu/drm/panel/panel-novatek-nt36523.c | 804 +++++++++---------
 include/drm/drm_mipi_dsi.h                    | 118 ++-
 5 files changed, 614 insertions(+), 608 deletions(-)


base-commit: ca2a6abdaee43808034cdb218428d2ed85fd3db8
-- 
2.50.1


             reply	other threads:[~2025-07-22  1:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  1:53 Brigham Campbell [this message]
2025-07-22  1:53 ` [PATCH v6 1/4] drm: Create mipi_dsi_dual* macros Brigham Campbell
2025-07-22 16:20   ` Doug Anderson
2025-07-23 15:10     ` Brigham Campbell
2025-07-22  1:53 ` [PATCH v6 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver Brigham Campbell
2025-07-22 16:31   ` Doug Anderson
2025-07-22  1:53 ` [PATCH v6 3/4] drm: Remove unused MIPI write seq and chatty functions Brigham Campbell
2025-07-22 19:05   ` Dmitry Baryshkov
2025-07-22  1:53 ` [PATCH v6 4/4] drm: docs: Update task from drm TODO list Brigham Campbell
2025-07-29 15:42 ` [PATCH v6 0/4] drm: Fix bug in panel driver, update MIPI support macros Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722015313.561966-1-me@brighamcampbell.com \
    --to=me@brighamcampbell.com \
    --cc=dianders@chromium.org \
    --cc=diogo.ivo@tecnico.ulisboa.pt \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tejasvipin76@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox