Re: [PATCH] iio: adc: ad7768-1: Remove logically dead code

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 16 Aug 2025 19:07:55 +0530
Chandra Mohan Sundar <chandramohan.explore@gmail.com> wrote:

> The clamp macro returns a value within the specified range.
> 
> In ad7768_set_freq(), the value returned from clamp() is checked against
> zero, which is not possible since the value would always be between
> 50 and 1024000.
> 
> Removed the 'if' check.
> 
> This issue was reported by static coverity analyser as logically
> dead code.
> 
> Fixes: fb1d3b24ebf5c ("iio: adc: ad7768-1: add filter type and oversampling ratio attributes")
Applied but dropped the fixes tag. No need to encourage people to backport
this.

Jonathan

> Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
> ---
>  drivers/iio/adc/ad7768-1.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index ca8fa91796ca..a27591bbf7df 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -687,8 +687,6 @@ static int ad7768_set_freq(struct ad7768_state *st,
>  	int ret;
>  
>  	freq = clamp(freq, 50, 1024000);
> -	if (freq == 0)
> -		return -EINVAL;
>  
>  	mclk_div = DIV_ROUND_CLOSEST(st->mclk_freq, freq * st->oversampling_ratio);
>  	/* Find the closest match for the desired sampling frequency */