From: Yixun Lan <dlan@gentoo.org>
To: Hendrik Hamerlinck <hendrik.hamerlinck@hammernet.be>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org, elder@riscstar.com
Subject: Re: [PATCH] riscv: dts: spacemit: add UART resets for Soc K1
Date: Thu, 21 Aug 2025 07:06:05 +0800 [thread overview]
Message-ID: <20250820230605-GYA1065530@gentoo> (raw)
In-Reply-To: <1a4a25d2-25a1-4d06-bba6-50f51cfbb619@hammernet.be>
On 20:27 Wed 20 Aug , Hendrik Hamerlinck wrote:
> Hello,
>
> On 8/7/25 21:18, Hendrik Hamerlinck wrote:
> > Add reset control entries for all UARTs in the SpaceMIT K1 SoC Device Tree.
> > UART0 was functional as it did not need a reset. But the other UARTs were
> > unable to access their registers without the reset being applied.
> >
> > Although perhaps not needed I did add the reset for UART0 as well,
> > to ensure consistency across all UARTs. With the current-speed set to
> > 112500 baud rate, it matches the factory U-Boot settings.
> > This should not give issues with early console usage. But perhaps it could
> > be a good idea to let somebody else confirm this as well.
> I have tested this version for a while and no longer see the need for
> additional confirmation.
>
> >
> > Tested this locally on both Orange Pi RV2 and Banana Pi BPI-F3 boards.
> > I enabled the UART9 and was able to use it successfully.
> >
> Just a gentle reminder about this patch.
>
> All UARTs are listed in the K1 device tree and probed by the 8250_of driver,
> but without reset lines most of them are non-functional. Adding the resets
> makes them usable when mapped to devices.
>
that probably due to other UARTs are in assert mode by default, while
UART0 already configured by bootloader..
> This patch is limited to DTS reset handling, so UARTs are usable in the
> current state. I’m aware Alex Elder is assigned to the UART peripheral on
> the wiki and will likely handle the broader driver improvements (DMA,
> clock updates, full baud-rate support), so this should not interfere with
> that work.
>
> Thanks for taking a look!
>
> Kind regards,
> Hendrik
>
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2025-08-20 23:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 19:18 [PATCH] riscv: dts: spacemit: add UART resets for Soc K1 Hendrik Hamerlinck
2025-08-20 18:27 ` Hendrik Hamerlinck
2025-08-20 23:06 ` Yixun Lan [this message]
2025-08-20 23:19 ` Yixun Lan
2025-08-21 8:12 ` Hendrik Hamerlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820230605-GYA1065530@gentoo \
--to=dlan@gentoo.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@riscstar.com \
--cc=hendrik.hamerlinck@hammernet.be \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox