Re: [PATCH 1/5] dt-bindings: iio: imu: Add ICM-20948

Krzysztof Kozlowski
2025-08-31T12:57:44Z

On 30/08/2025 20:42, Bharadwaj Raju wrote:
> +description: |
> + 9-axis motion-tracking device that combines a 3-axis gyroscope, 3-axis
> + accelerometer, and a 3-axis magnetometer.
> +
> + https://invensense.tdk.com/wp-content/uploads/2024/03/DS-000189-ICM-20948-v1.6.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - invensense,icm20948
> +

That's pretty incomplete. See existing invense bindings. Explain in
commit msg how this is different than existing devices.

> + reg:
> + maxItems: 1
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + icm20948 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> + compatible = "invensense,icm20948";
> + reg = <0x69>;
> + }
> + }
>

Best regards,
Krzysztof