From: Jakub Kicinski <kuba@kernel.org>
To: Maksimilijan Marosevic <maksimilijan.marosevic@proton.me>
Cc: davem@davemloft.net, dsahern@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
syzbot+a259a17220263c2d73fc@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/1] ipv6: Check AF_UNSPEC in ip6_route_multipath_add()
Date: Thu, 4 Sep 2025 09:03:01 -0700 [thread overview]
Message-ID: <20250904090301.552ef178@kernel.org> (raw)
In-Reply-To: <20250804204233.1332529-1-maksimilijan.marosevic@proton.me>
On Mon, 04 Aug 2025 20:42:53 +0000 Maksimilijan Marosevic wrote:
> This check was removed in commit e6f497955fb6 ("ipv6: Check GATEWAY
> in rtm_to_fib6_multipath_config().") as part of rt6_qualify_for ecmp().
> The author correctly recognises that rt6_qualify_for_ecmp() returns
> false if fb_nh_gw_family is set to AF_UNSPEC, but then mistakes
> AF_UNSPEC for AF_INET6 when reasoning that the check is unnecessary.
> This means certain malformed entries don't get caught in
> ip6_route_multipath_add().
>
> This patch reintroduces the AF_UNSPEC check while respecting changes
> of the initial patch.
Hi Maksimilijan!
Are you planning to repost this with a test?
If not I suppose we can enlist the author of the commit to help with
the selftest..
prev parent reply other threads:[~2025-09-04 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 20:42 [PATCH 1/1] ipv6: Check AF_UNSPEC in ip6_route_multipath_add() Maksimilijan Marosevic
2025-08-05 16:16 ` David Ahern
2025-08-12 8:16 ` Paolo Abeni
2025-09-04 16:03 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904090301.552ef178@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=maksimilijan.marosevic@proton.me \
--cc=netdev@vger.kernel.org \
--cc=syzbot+a259a17220263c2d73fc@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox