* [PATCH] docs: perf: cleanup fujitsu_uncore_pmu.rst and fix htmldocs warnings/errors
@ 2025-09-25 19:54 Gopi Krishna Menon
2025-09-25 20:06 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Gopi Krishna Menon @ 2025-09-25 19:54 UTC (permalink / raw)
To: corbet, fj2767dz, will, yangyicong
Cc: Gopi Krishna Menon, linux-doc, linux-kernel, skhan,
david.hunter.linux, linux-kernel-mentees
- Adjust spacing around list and sections for better readability.
- Use definition lists for defining events.
- Replace block quotes with code blocks where appropriate.
Fixes the following htmldocs errors/warnings:
Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:20: ERROR: Unexpected indentation.
Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:23: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:28: ERROR: Unexpected indentation.
Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:29: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:81: ERROR: Unexpected indentation.
Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:82: WARNING: Block quote ends without a blank line; unexpected unindent.
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
.../admin-guide/perf/fujitsu_uncore_pmu.rst | 130 ++++++++++++------
1 file changed, 87 insertions(+), 43 deletions(-)
diff --git a/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst b/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst
index 46595b788d3a..577bad243876 100644
--- a/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst
+++ b/Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst
@@ -6,105 +6,149 @@ Fujitsu Uncore Performance Monitoring Unit (PMU)
This driver supports the Uncore MAC PMUs and the Uncore PCI PMUs found
in Fujitsu chips.
+
Each MAC PMU on these chips is exposed as a uncore perf PMU with device name
-mac_iod<iod>_mac<mac>_ch<ch>.
+``mac_iod<iod>_mac<mac>_ch<ch>``.
+
And each PCI PMU on these chips is exposed as a uncore perf PMU with device name
-pci_iod<iod>_pci<pci>.
+``pci_iod<iod>_pci<pci>``.
The driver provides a description of its available events and configuration
-options in sysfs, see /sys/bus/event_sources/devices/mac_iod<iod>_mac<mac>_ch<ch>/
-and /sys/bus/event_sources/devices/pci_iod<iod>_pci<pci>/.
+options in sysfs, see ``/sys/bus/event_sources/devices/mac_iod<iod>_mac<mac>_ch<ch>/``
+and ``/sys/bus/event_sources/devices/pci_iod<iod>_pci<pci>/``.
+
This driver exports:
-- formats, used by perf user space and other tools to configure events
+====================
+
+- formats, used by perf user space and other tools to configure events.
- events, used by perf user space and other tools to create events
- symbolically, e.g.:
- perf stat -a -e mac_iod0_mac0_ch0/event=0x21/ ls
- perf stat -a -e pci_iod0_pci0/event=0x24/ ls
+ symbolically, e.g:
+
+ .. code-block:: bash
+
+ perf stat -a -e mac_iod0_mac0_ch0/event=0x21/ ls
+ perf stat -a -e pci_iod0_pci0/event=0x24/ ls
+
- cpumask, used by perf user space and other tools to know on which CPUs
to open the events
This driver supports the following events for MAC:
-- cycles
+--------------------------------------------------
+
+cycles:
This event counts MAC cycles at MAC frequency.
-- read-count
+
+read-count:
This event counts the number of read requests to MAC.
-- read-count-request
+
+read-count-request:
This event counts the number of read requests including retry to MAC.
-- read-count-return
+
+read-count-return:
This event counts the number of responses to read requests to MAC.
-- read-count-request-pftgt
+
+read-count-request-pftgt:
This event counts the number of read requests including retry with PFTGT
flag.
-- read-count-request-normal
+
+read-count-request-normal:
This event counts the number of read requests including retry without PFTGT
flag.
-- read-count-return-pftgt-hit
+
+read-count-return-pftgt-hit:
This event counts the number of responses to read requests which hit the
PFTGT buffer.
-- read-count-return-pftgt-miss
+
+read-count-return-pftgt-miss:
This event counts the number of responses to read requests which miss the
PFTGT buffer.
-- read-wait
+
+read-wait:
This event counts outstanding read requests issued by DDR memory controller
per cycle.
-- write-count
+
+write-count:
This event counts the number of write requests to MAC (including zero write,
full write, partial write, write cancel).
-- write-count-write
+
+write-count-write:
This event counts the number of full write requests to MAC (not including
zero write).
-- write-count-pwrite
+
+write-count-pwrite:
This event counts the number of partial write requests to MAC.
-- memory-read-count
+
+memory-read-count:
This event counts the number of read requests from MAC to memory.
-- memory-write-count
+
+memory-write-count:
This event counts the number of full write requests from MAC to memory.
-- memory-pwrite-count
+
+memory-pwrite-count:
This event counts the number of partial write requests from MAC to memory.
-- ea-mac
+
+ea-mac:
This event counts energy consumption of MAC.
-- ea-memory
+
+ea-memory:
This event counts energy consumption of memory.
-- ea-memory-mac-write
+
+ea-memory-mac-write:
This event counts the number of write requests from MAC to memory.
-- ea-ha
+
+ea-ha:
This event counts energy consumption of HA.
'ea' is the abbreviation for 'Energy Analyzer'.
-Examples for use with perf::
+Examples for use with perf
+
+ .. code-block:: bash
- perf stat -e mac_iod0_mac0_ch0/ea-mac/ ls
+ perf stat -e mac_iod0_mac0_ch0/ea-mac/ ls
And, this driver supports the following events for PCI:
-- pci-port0-cycles
+
+pci-port0-cycles:
This event counts PCI cycles at PCI frequency in port0.
-- pci-port0-read-count
+
+pci-port0-read-count:
This event counts read transactions for data transfer in port0.
-- pci-port0-read-count-bus
+
+pci-port0-read-count-bus:
This event counts read transactions for bus usage in port0.
-- pci-port0-write-count
+
+pci-port0-write-count:
This event counts write transactions for data transfer in port0.
-- pci-port0-write-count-bus
+
+pci-port0-write-count-bus:
This event counts write transactions for bus usage in port0.
-- pci-port1-cycles
+
+pci-port1-cycles:
This event counts PCI cycles at PCI frequency in port1.
-- pci-port1-read-count
+
+pci-port1-read-count:
This event counts read transactions for data transfer in port1.
-- pci-port1-read-count-bus
+
+pci-port1-read-count-bus:
This event counts read transactions for bus usage in port1.
-- pci-port1-write-count
+
+pci-port1-write-count:
This event counts write transactions for data transfer in port1.
-- pci-port1-write-count-bus
+
+pci-port1-write-count-bus:
This event counts write transactions for bus usage in port1.
-- ea-pci
+
+ea-pci:
This event counts energy consumption of PCI.
- 'ea' is the abbreviation for 'Energy Analyzer'.
+ 'ea' is the abbreviation for 'Energy Analyzer'.
+
+Examples for use with perf:
-Examples for use with perf::
+ .. code-block:: bash
- perf stat -e pci_iod0_pci0/ea-pci/ ls
+ perf stat -e pci_iod0_pci0/ea-pci/ ls
Given that these are uncore PMUs the driver does not support sampling, therefore
"perf record" will not work. Per-task perf sessions are not supported.
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] docs: perf: cleanup fujitsu_uncore_pmu.rst and fix htmldocs warnings/errors
2025-09-25 19:54 [PATCH] docs: perf: cleanup fujitsu_uncore_pmu.rst and fix htmldocs warnings/errors Gopi Krishna Menon
@ 2025-09-25 20:06 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2025-09-25 20:06 UTC (permalink / raw)
To: Gopi Krishna Menon, corbet, fj2767dz, will, yangyicong
Cc: linux-doc, linux-kernel, david.hunter.linux, linux-kernel-mentees,
Shuah Khan
On 9/25/25 13:54, Gopi Krishna Menon wrote:
> - Adjust spacing around list and sections for better readability.
> - Use definition lists for defining events.
> - Replace block quotes with code blocks where appropriate.
The bullet list type format used above isn't right format for
change log. Refer to a few change logs and also check submitting
patches documentation.
Sounds like you are combining formatting changes and warning
fixes. These are better done as separate patches.
>
> Fixes the following htmldocs errors/warnings:
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:20: ERROR: Unexpected indentation.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:23: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:28: ERROR: Unexpected indentation.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:29: WARNING: Block quote ends without a blank line; unexpected unindent.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:81: ERROR: Unexpected indentation.
> Documentation/admin-guide/perf/fujitsu_uncore_pmu.rst:82: WARNING: Block quote ends without a blank line; unexpected unindent.
>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> .../admin-guide/perf/fujitsu_uncore_pmu.rst | 130 ++++++++++++------
> 1 file changed, 87 insertions(+), 43 deletions(-)
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-25 20:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-25 19:54 [PATCH] docs: perf: cleanup fujitsu_uncore_pmu.rst and fix htmldocs warnings/errors Gopi Krishna Menon
2025-09-25 20:06 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox