From: vivekyadav1207731111@gmail.com
To: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev,
david.hunter.linux@gmail.com,
Vivek Yadav <vivekyadav1207731111@gmail.com>
Subject: [PATCH] usb: serial: fix: space prohibited before comma separator
Date: Sat, 4 Oct 2025 12:26:18 +0530 [thread overview]
Message-ID: <20251004065618.70151-1-vivekyadav1207731111@gmail.com> (raw)
From: Vivek Yadav <vivekyadav1207731111@gmail.com>
Run `checkpatch.pl` script on path `drivers/usb/serial/*`.
Find ERROR: space prohibited before that ',' (ctx:WxE).
Doesn't claim any functionality changes in any of the modified
file.
Signed-off-by: Vivek Yadav <vivekyadav1207731111@gmail.com>
---
drivers/usb/serial/ark3116.c | 12 ++++++------
drivers/usb/serial/ftdi_sio.c | 2 +-
drivers/usb/serial/iuu_phoenix.c | 4 ++--
drivers/usb/serial/keyspan_usa90msg.h | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index 800b04fe37fa..f1cc4e36e4e6 100644
--- a/drivers/usb/serial/ark3116.c
+++ b/drivers/usb/serial/ark3116.c
@@ -143,18 +143,18 @@ static int ark3116_port_probe(struct usb_serial_port *port)
ark3116_write_reg(serial, UART_FCR, 0);
/* handshake control */
priv->hcr = 0;
- ark3116_write_reg(serial, 0x8 , 0);
+ ark3116_write_reg(serial, 0x8, 0);
/* modem control */
priv->mcr = 0;
ark3116_write_reg(serial, UART_MCR, 0);
if (!(priv->irda)) {
- ark3116_write_reg(serial, 0xb , 0);
+ ark3116_write_reg(serial, 0xb, 0);
} else {
- ark3116_write_reg(serial, 0xb , 1);
- ark3116_write_reg(serial, 0xc , 0);
- ark3116_write_reg(serial, 0xd , 0x41);
- ark3116_write_reg(serial, 0xa , 1);
+ ark3116_write_reg(serial, 0xb, 1);
+ ark3116_write_reg(serial, 0xc, 0);
+ ark3116_write_reg(serial, 0xd, 0x41);
+ ark3116_write_reg(serial, 0xa, 1);
}
/* setup baudrate */
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 49666c33b41f..f5d4335c4f6c 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -190,7 +190,7 @@ static const struct usb_device_id id_table_combined[] = {
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_8U232AM_ALT_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_232RL_PID) },
- { USB_DEVICE(FTDI_VID, FTDI_8U2232C_PID) ,
+ { USB_DEVICE(FTDI_VID, FTDI_8U2232C_PID),
.driver_info = (kernel_ulong_t)&ftdi_8u2232c_quirk },
{ USB_DEVICE(FTDI_VID, FTDI_4232H_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_232H_PID) },
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index c21dcc9b6f05..fc71aaea3229 100644
--- a/drivers/usb/serial/iuu_phoenix.c
+++ b/drivers/usb/serial/iuu_phoenix.c
@@ -360,7 +360,7 @@ static void iuu_led_activity_on(struct urb *urb)
usb_fill_bulk_urb(port->write_urb, port->serial->dev,
usb_sndbulkpipe(port->serial->dev,
port->bulk_out_endpointAddress),
- port->write_urb->transfer_buffer, 8 ,
+ port->write_urb->transfer_buffer, 8,
iuu_rxcmd, port);
usb_submit_urb(port->write_urb, GFP_ATOMIC);
}
@@ -380,7 +380,7 @@ static void iuu_led_activity_off(struct urb *urb)
usb_fill_bulk_urb(port->write_urb, port->serial->dev,
usb_sndbulkpipe(port->serial->dev,
port->bulk_out_endpointAddress),
- port->write_urb->transfer_buffer, 8 ,
+ port->write_urb->transfer_buffer, 8,
iuu_rxcmd, port);
usb_submit_urb(port->write_urb, GFP_ATOMIC);
}
diff --git a/drivers/usb/serial/keyspan_usa90msg.h b/drivers/usb/serial/keyspan_usa90msg.h
index c4ca0f631d20..e01df75140c7 100644
--- a/drivers/usb/serial/keyspan_usa90msg.h
+++ b/drivers/usb/serial/keyspan_usa90msg.h
@@ -69,7 +69,7 @@ struct keyspan_usa90_portControlMessage
txMode, // TXMODE_DMA or TXMODE_BYHAND
setTxFlowControl, // host requests tx flow control be set
- txFlowControl , // use TX_FLOW... bits below
+ txFlowControl, // use TX_FLOW... bits below
setRxFlowControl, // host requests rx flow control be set
rxFlowControl, // use RX_FLOW... bits below
sendXoff, // host requests XOFF transmitted immediately
--
2.43.0
next reply other threads:[~2025-10-04 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-04 6:56 vivekyadav1207731111 [this message]
2025-10-06 12:12 ` [PATCH] usb: serial: fix: space prohibited before comma separator Johan Hovold
2025-10-06 17:54 ` vivek yadav
2025-10-07 1:03 ` David Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251004065618.70151-1-vivekyadav1207731111@gmail.com \
--to=vivekyadav1207731111@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox