From: Adrian Yip <adrian.ytw@gmail.com>
To: stable@vger.kernel.org
Cc: "Mario Limonciello" <mario.limonciello@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
david.hunter.linux@gmail.com, khalid@kernel.org,
"Adrian Yip" <adrian.ytw@gmail.com>
Subject: [PATCH 1/4 6.17.y] drm/amd: Check whether secure display TA loaded successfully
Date: Sat, 18 Oct 2025 11:56:41 -0500 [thread overview]
Message-ID: <20251018165653.1939869-2-adrian.ytw@gmail.com> (raw)
In-Reply-To: <20251018165653.1939869-1-adrian.ytw@gmail.com>
From: Mario Limonciello <mario.limonciello@amd.com>
commit c760bcda83571e07b72c10d9da175db5051ed971 upstream
[Why]
Not all renoir hardware supports secure display. If the TA is present
but the feature isn't supported it will fail to load or send commands.
This shows ERR messages to the user that make it seems like there is
a problem.
[How]
Check the resp_status of the context to see if there was an error
before trying to send any secure display commands.
There were no code conflict when applying to 6.17.y.
This backport gets rid of below error messages on AMD GPUs (per Shuah
Khan's machine)
kern :err :
amdgpu 0000:0b:00.0: amdgpu: Secure display: Generic Failure.
amdgpu 0000:0b:00.0: amdgpu: SECUREDISPLAY: query securedisplay TA
failed. ret 0x0
Compile test was done.
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1415
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit c760bcda83571e07b72c10d9da175db5051ed971)
Cc: <stable@vger.kernel.org>
Signed-off-by: Adrian Yip <adrian.ytw@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 693357caa9a8..d9d7fc4c33cb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -2350,7 +2350,7 @@ static int psp_securedisplay_initialize(struct psp_context *psp)
}
ret = psp_ta_load(psp, &psp->securedisplay_context.context);
- if (!ret) {
+ if (!ret && !psp->securedisplay_context.context.resp_status) {
psp->securedisplay_context.context.initialized = true;
mutex_init(&psp->securedisplay_context.mutex);
} else
--
2.51.0
next prev parent reply other threads:[~2025-10-18 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 16:56 [PATCH 0/4] drm/amd: Check whether secure display TA loaded successfully Adrian Yip
2025-10-18 16:56 ` Adrian Yip [this message]
2025-10-18 16:56 ` [PATCH 2/4 6.12.y] " Adrian Yip
2025-10-20 9:07 ` Greg KH
2025-10-18 16:56 ` [PATCH 3/4 6.6.y] " Adrian Yip
2025-10-18 16:56 ` [PATCH 4/4 6.1.y] " Adrian Yip
2025-10-20 9:06 ` [PATCH 0/4] " Greg KH
2025-10-20 10:22 ` Adrian Yip
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251018165653.1939869-2-adrian.ytw@gmail.com \
--to=adrian.ytw@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=mario.limonciello@amd.com \
--cc=simona@ffwll.ch \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox