Re: [PATCH v2] mmc: pxamci: Simplify pxamci_probe() error handling using devm APIs

Uwe Kleine-König
2025-10-23T12:58:27Z

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Hello Rakuram,

On Thu, Oct 23, 2025 at 05:28:17PM +0530, Rakuram Eswaran wrote:
> On Tue, 21 Oct 2025 at 14:01, Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:
> > Yes, I suggest to make restructuring .remote a separate patch. (But
> > removing dma_release_channel belongs into the patch that introduces devm
> > to allocate the dma channels.)
>
> I believe ".remote" is a typo and you're referring to the _remove() function.
> Removing if(mmc) condition check from pxamci_remove() can be handled in a
> separate cleanup patch, while removing redundant dma_release_channel()
> will be included in v3.
>
> Is my above understanding correct?

ack. remote vs. remove is one of my most-committed typos :-D

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]