* [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore
@ 2025-10-24 16:19 Gopi Krishna Menon
2025-10-26 2:56 ` David Hunter
0 siblings, 1 reply; 7+ messages in thread
From: Gopi Krishna Menon @ 2025-10-24 16:19 UTC (permalink / raw)
To: shuah
Cc: Gopi Krishna Menon, linux-kselftest, linux-kernel,
david.hunter.linux, skhan, linux-kernel-mentees, khalid
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
staging the build artifact.
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
tools/testing/selftests/tty/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
index fe70462a4aad..2453685d2493 100644
--- a/tools/testing/selftests/tty/.gitignore
+++ b/tools/testing/selftests/tty/.gitignore
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
+tty_tiocsti_test
tty_tstamp_update
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore
2025-10-24 16:19 [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore Gopi Krishna Menon
@ 2025-10-26 2:56 ` David Hunter
2025-10-26 7:25 ` [PATCH v2] " Gopi Krishna Menon
0 siblings, 1 reply; 7+ messages in thread
From: David Hunter @ 2025-10-26 2:56 UTC (permalink / raw)
To: Gopi Krishna Menon, shuah
Cc: linux-kselftest, linux-kernel, skhan, linux-kernel-mentees,
khalid
On 10/24/25 12:19, Gopi Krishna Menon wrote:
> Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
> staging the build artifact.
>
Why do we want to ignore building this artifact? When submitting a
patch, it is important to list "why" something is needed. Not just what
is done.
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> tools/testing/selftests/tty/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
> index fe70462a4aad..2453685d2493 100644
> --- a/tools/testing/selftests/tty/.gitignore
> +++ b/tools/testing/selftests/tty/.gitignore
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +tty_tiocsti_test
> tty_tstamp_update
Thanks,
David Hunter
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore
2025-10-26 2:56 ` David Hunter
@ 2025-10-26 7:25 ` Gopi Krishna Menon
2025-10-26 8:35 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Gopi Krishna Menon @ 2025-10-26 7:25 UTC (permalink / raw)
To: shuah
Cc: Gopi Krishna Menon, linux-kselftest, linux-kernel,
david.hunter.linux, skhan, linux-kernel-mentees, khalid
Building the tty selftests generates the tty_tiocsti_test binary, which
appears as untracked file in git. As mentioned in the kselftest
documentation, all the generated objects must be placed inside
.gitignore. This prevents the generated objects from accidentally
getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
Suggested-by: David Hunter <david.hunter.linux@gmail.com>
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Changelog:
- Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
index fe70462a4aad..2453685d2493 100644
--- a/tools/testing/selftests/tty/.gitignore
+++ b/tools/testing/selftests/tty/.gitignore
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
+tty_tiocsti_test
tty_tstamp_update
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore
2025-10-26 7:25 ` [PATCH v2] " Gopi Krishna Menon
@ 2025-10-26 8:35 ` Greg KH
2025-10-26 9:22 ` Gopi Krishna Menon
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2025-10-26 8:35 UTC (permalink / raw)
To: Gopi Krishna Menon
Cc: shuah, linux-kselftest, linux-kernel, david.hunter.linux, skhan,
linux-kernel-mentees, khalid
On Sun, Oct 26, 2025 at 12:55:46PM +0530, Gopi Krishna Menon wrote:
> Building the tty selftests generates the tty_tiocsti_test binary, which
> appears as untracked file in git. As mentioned in the kselftest
> documentation, all the generated objects must be placed inside
> .gitignore. This prevents the generated objects from accidentally
> getting staged and keeps the working tree clean.
>
> Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
> staging the build artifact and maintain a clean working tree.
>
> Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
>
> Suggested-by: David Hunter <david.hunter.linux@gmail.com>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> Changelog:
> - Improve the commit wording and explain clearly why this change is needed.
>
> tools/testing/selftests/tty/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
> index fe70462a4aad..2453685d2493 100644
> --- a/tools/testing/selftests/tty/.gitignore
> +++ b/tools/testing/selftests/tty/.gitignore
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +tty_tiocsti_test
> tty_tstamp_update
> --
> 2.43.0
>
>
Shouldn't this go through the tty tree that added this test?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore
2025-10-26 8:35 ` Greg KH
@ 2025-10-26 9:22 ` Gopi Krishna Menon
2025-10-26 9:35 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Gopi Krishna Menon @ 2025-10-26 9:22 UTC (permalink / raw)
To: gregkh, jirislaby
Cc: Gopi Krishna Menon, linux-kselftest, linux-kernel, linux-serial,
david.hunter.linux, xandfury, skhan, linux-kernel-mentees, khalid
Building the tty selftests generates the tty_tiocsti_test binary, which
appears as untracked file in git. As mentioned in the kselftest
documentation, all the generated objects must be placed inside
.gitignore. This prevents the generated objects from accidentally
getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
Suggested-by: David Hunter <david.hunter.linux@gmail.com>
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Changelog:
- Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
index fe70462a4aad..2453685d2493 100644
--- a/tools/testing/selftests/tty/.gitignore
+++ b/tools/testing/selftests/tty/.gitignore
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
+tty_tiocsti_test
tty_tstamp_update
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] selftests: tty: add tty_tiocsti_test to .gitignore
2025-10-26 9:22 ` Gopi Krishna Menon
@ 2025-10-26 9:35 ` Greg KH
2025-10-26 10:00 ` [PATCH v3] " Gopi Krishna Menon
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2025-10-26 9:35 UTC (permalink / raw)
To: Gopi Krishna Menon
Cc: jirislaby, linux-kselftest, linux-kernel, linux-serial,
david.hunter.linux, xandfury, skhan, linux-kernel-mentees, khalid
On Sun, Oct 26, 2025 at 02:52:32PM +0530, Gopi Krishna Menon wrote:
> Building the tty selftests generates the tty_tiocsti_test binary, which
> appears as untracked file in git. As mentioned in the kselftest
> documentation, all the generated objects must be placed inside
> .gitignore. This prevents the generated objects from accidentally
> getting staged and keeps the working tree clean.
>
> Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
> staging the build artifact and maintain a clean working tree.
>
> Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
>
> Suggested-by: David Hunter <david.hunter.linux@gmail.com>
> Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
> ---
> Changelog:
> - Improve the commit wording and explain clearly why this change is needed.
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] selftests: tty: add tty_tiocsti_test to .gitignore
2025-10-26 9:35 ` Greg KH
@ 2025-10-26 10:00 ` Gopi Krishna Menon
0 siblings, 0 replies; 7+ messages in thread
From: Gopi Krishna Menon @ 2025-10-26 10:00 UTC (permalink / raw)
To: gregkh, jirislaby
Cc: Gopi Krishna Menon, linux-kselftest, linux-kernel, linux-serial,
david.hunter.linux, xandfury, skhan, linux-kernel-mentees, khalid
Building the tty selftests generates the tty_tiocsti_test binary, which
appears as untracked file in git. As mentioned in the kselftest
documentation, all the generated objects must be placed inside
.gitignore. This prevents the generated objects from accidentally
getting staged and keeps the working tree clean.
Add the tty_tiocsti_test binary to .gitignore to avoid accidentally
staging the build artifact and maintain a clean working tree.
Link: https://docs.kernel.org/dev-tools/kselftest.html#contributing-new-tests-details
Fixes: 7553f5173ec3 ("selftests/tty: add TIOCSTI test suite")
Suggested-by: Greg KH <gregkh@linuxfoundation.org>
Suggested-by: David Hunter <david.hunter.linux@gmail.com>
Signed-off-by: Gopi Krishna Menon <krishnagopi487@gmail.com>
---
Changelog:
v3:
- Add fixes tag as suggested by Greg KH.
v2:
- Improve the commit wording and explain clearly why this change is needed.
tools/testing/selftests/tty/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tty/.gitignore b/tools/testing/selftests/tty/.gitignore
index fe70462a4aad..2453685d2493 100644
--- a/tools/testing/selftests/tty/.gitignore
+++ b/tools/testing/selftests/tty/.gitignore
@@ -1,2 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
+tty_tiocsti_test
tty_tstamp_update
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-10-26 10:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-24 16:19 [PATCH] selftests: tty: add tty_tiocsti_test to .gitignore Gopi Krishna Menon
2025-10-26 2:56 ` David Hunter
2025-10-26 7:25 ` [PATCH v2] " Gopi Krishna Menon
2025-10-26 8:35 ` Greg KH
2025-10-26 9:22 ` Gopi Krishna Menon
2025-10-26 9:35 ` Greg KH
2025-10-26 10:00 ` [PATCH v3] " Gopi Krishna Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox