Re: [PATCH v3] dt_bindings: sound: ti,pcm186x: convert to dtschema

Conor Dooley
2025-10-29T17:46:33Z

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Wed, Oct 29, 2025 at 10:53:04AM +0530, Ranganath V N wrote:
> convert the Texas Instruments PCM186x Universal audio ADC bindings
> to DT schema.
>
> Signed-off-by: Ranganath V N <vnranganath.20@gmail.com>
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm186x.yaml b/Documentation/devicetree/bindings/sound/ti,pcm186x.yaml

> +properties:
> + compatible:
> + enum:
> + - ti,pcm1862
> + - ti,pcm1863
> + - ti,pcm1864
> + - ti,pcm1865

Usually we want the filename to match one of compatibles in the file,
rather than have wildcards.

Secondly, the subject is not really as expected for a binding, let alone
one in sound. It should be "ASoC: dt-bindings: ".

With those,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: changes-requested

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]