Re: [PATCH v5] Asoc: dt_bindings: ti,pcm186x: convert to dtschema

Krzysztof Kozlowski
2025-11-02T16:10:51Z

On Fri, Oct 31, 2025 at 12:29:02PM +0530, Ranganath V N wrote:
> convert the Texas Instruments PCM186x Universal audio ADC bindings
> to DT schema.
>
> Signed-off-by: Ranganath V N <vnranganath.20@gmail.com>

Conor asked you to fix subject. You still did not implement the entire
fix. Please read the feedback with care.

It is never "dt_bindings".

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> ---
> Convert the Texas Instruments PCM186x audio ADC bindings to DT schema.
> ---
> Changes in v5:
> - Resolved previous patch warnings/errors
> - dtschema/dtc warnings/errors:
> - /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/ti,pcm1862.yaml:
> - $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
> - $id: http://devicetree.org/schemas/sound/ti,pcm186x.yaml
> - file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/ti,pcm1862.yaml
> - Link to v4: https://lore.kernel.org/r/20251030-dtbs-v4-1-3fff32221119@gmail.com
>
> Changes in v4:
> - Corrected subject dt_bindings:sound to Asoc: dt_bindings:
> - Corrected the filename to match one of the compitables in the file
> - ti,pcm186x.yaml to ti,pcm1862.yaml
> - Link to v3: https://lore.kernel.org/r/20251029-dtbs-v3-1-3cc162221c22@gmail.com
>
> Changes in v3:
> - Unicode FEFF character was present in the begining of the file,
> - Removed unicode character.
> - Link to v2: https://lore.kernel.org/r/20251026-dtbs-v2-1-cd3b713a288e@gmail.com
>
> Changes in v2:
> - Fixes as per the reviews suggested for the v1.
> - Link to v1: https://lore.kernel.org/r/20251021-dtbs-v1-1-493c1aa253bc@gmail.com
> ---
> .../devicetree/bindings/sound/pcm186x.txt | 42 ---------------
> .../devicetree/bindings/sound/ti,pcm1862.yaml | 61 ++++++++++++++++++++++
> 2 files changed, 61 insertions(+), 42 deletions(-)
>

...

> +
> +maintainers:
> + - Ranganath V N <vnranganath.20@gmail.com>

This means you actually care about this particular binding and hardware
and has some sort of access to datasheet or hardware. If this is true,
then it is fine.

> +
> +description:
> + The Texas Instruments PCM186x family are multi-channel audio ADCs
> + that support both I2C and SPI control interfaces, selected by
> + pin strapping. These devices include on-chip programmable gain
> + amplifiers and support differential or single-ended analog inputs.
> +
> +properties:
> + compatible:
> + enum:
> + - ti,pcm1862
> + - ti,pcm1863
> + - ti,pcm1864
> + - ti,pcm1865
> +
> + reg:
> + maxItems: 1
> +
> + avdd-supply: true
> +
> + dvdd-supply: true
> +
> + iovdd-supply: true
> +
> + '#sound-dai-cells':

This wasn't in the old binding and nothing in commit msg explains the
changes. You MUST document in commit msg ALL the changes you made during
conversion from the original binding. Otherwise you just add some sort
of properties and why would we accept such a change?

If this is DAI, then you miss ref to dai-common and use
unevaluatedProperties. See all other DAI bindings.

> + const: 0

Best regards,
Krzysztof