From: Greg KH <gregkh@linuxfoundation.org>
To: Clint George <clintbgeorge@gmail.com>
Cc: arnd@arndb.de, linux-kernel-mentees@lists.linux.dev,
skhan@linuxfoundation.org, khalid@kernel.org,
david.hunter.linux@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hangcheck-timer: use pr_crit and fix coding style
Date: Thu, 6 Nov 2025 16:51:28 +0900 [thread overview]
Message-ID: <2025110649-elves-steadying-a4d0@gregkh> (raw)
In-Reply-To: <20251105140541.9658-1-clintbgeorge@gmail.com>
On Wed, Nov 05, 2025 at 07:35:41PM +0530, Clint George wrote:
> Fix coding style issues and improve logging in hangcheck-timer such as replace printk(KERN_CRIT ...) to pr_crit(...) where applicable and replace non-standard %Ld with %lld in debug prints and use proper pr_debug/pr_crit for kernel logging.
Please wrap changelog comments at 72 columns.
Also, please split this up into "one patch per logical thing", as you
shouldn't be mixing them into one change.
thanks,
greg k-h
next prev parent reply other threads:[~2025-11-06 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 14:05 [PATCH] hangcheck-timer: use pr_crit and fix coding style Clint George
2025-11-06 7:51 ` Greg KH [this message]
2025-11-11 15:13 ` [PATCH v2 0/3] hangcheck-timer: coding style improvements Clint George
2025-11-11 15:13 ` [PATCH v2 1/3] hangcheck-timer: replace printk(KERN_CRIT) with pr_crit Clint George
2025-11-11 15:13 ` [PATCH v2 2/3] hangcheck-timer: Replace %Ld with %lld Clint George
2025-11-11 15:13 ` [PATCH v2 3/3] hangcheck-timer: fix coding style spacing Clint George
-- strict thread matches above, loose matches on Subject: below --
2025-10-18 16:00 [PATCH] hangcheck-timer: use pr_crit and fix coding style Clint George
2025-10-22 12:24 ` David Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025110649-elves-steadying-a4d0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=clintbgeorge@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox