From: Erick Karanja <karanja99erick@gmail.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Jeff Hugo <jeff.hugo@oss.qualcomm.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Vivek Pernamitta <quic_vpernami@quicinc.com>,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
Erick Karanja <karanja99erick@gmail.com>
Subject: [PATCH] bus: arm-cci: Fix device node reference leak in cci_probe_ports()
Date: Sat, 8 Nov 2025 09:32:19 +0300 [thread overview]
Message-ID: <20251108063219.550810-1-karanja99erick@gmail.com> (raw)
Although the reference to the child node cp is
assigned later in the iteration, when an early break
occurs, the reference to child node needs to be
released.
Fixes: ed69bdd8fd9b2 ("drivers: bus: add ARM CCI support")
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
i = nb_ace + nb_ace_lite;
- if (i >= nb_cci_ports)
+ if (i >= nb_cci_ports) {
+ of_node_put(cp);
break;
+ }
if (of_property_read_string(cp, "interface-type",
&match_str)) {
--
2.43.0
reply other threads:[~2025-11-08 6:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251108063219.550810-1-karanja99erick@gmail.com \
--to=karanja99erick@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ioana.ciornei@nxp.com \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=quic_vpernami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox