From: Clint George <clintbgeorge@gmail.com>
To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
david.hunter.linux@gmail.com,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
khalid@kernel.org, Clint George <clintbgeorge@gmail.com>
Subject: [PATCH 5/8] usb: gadget: dummy_hcd: merge multi-line quoted strings into one line
Date: Wed, 19 Nov 2025 18:38:37 +0530 [thread overview]
Message-ID: <20251119130840.14309-6-clintbgeorge@gmail.com> (raw)
In-Reply-To: <20251119130840.14309-1-clintbgeorge@gmail.com>
Merge multi-line quoted strings into a single line to improve readability
and comply with kernel coding style. This reduces unnecessary line
breaks in string literals and makes the code easier to follow.
Signed-off-by: Clint George <clintbgeorge@gmail.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index d4b2dcbc4..1363de6fe 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -2133,8 +2133,7 @@ static int dummy_hub_control(
case USB_PORT_FEAT_SUSPEND:
if (hcd->speed == HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "USB_PORT_FEAT_SUSPEND req not "
- "supported for USB 3.0 roothub\n");
+ "USB_PORT_FEAT_SUSPEND req not supported for USB 3.0 roothub\n");
goto error;
}
if (dum_hcd->port_status & USB_PORT_STAT_SUSPEND) {
@@ -2174,8 +2173,7 @@ static int dummy_hub_control(
(wLength < USB_DT_SS_HUB_SIZE ||
wValue != (USB_DT_SS_HUB << 8))) {
dev_dbg(dummy_dev(dum_hcd),
- "Wrong hub descriptor type for "
- "USB 3.0 roothub.\n");
+ "Wrong hub descriptor type for USB 3.0 roothub.\n");
goto error;
}
if (hcd->speed == HCD_USB3)
@@ -2247,8 +2245,7 @@ static int dummy_hub_control(
case USB_PORT_FEAT_LINK_STATE:
if (hcd->speed != HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "USB_PORT_FEAT_LINK_STATE req not "
- "supported for USB 2.0 roothub\n");
+ "USB_PORT_FEAT_LINK_STATE req not supported for USB 2.0 roothub\n");
goto error;
}
/*
@@ -2261,8 +2258,7 @@ static int dummy_hub_control(
/* TODO: add suspend/resume support! */
if (hcd->speed != HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "USB_PORT_FEAT_U1/2_TIMEOUT req not "
- "supported for USB 2.0 roothub\n");
+ "USB_PORT_FEAT_U1/2_TIMEOUT req not supported for USB 2.0 roothub\n");
goto error;
}
break;
@@ -2270,8 +2266,7 @@ static int dummy_hub_control(
/* Applicable only for USB2.0 hub */
if (hcd->speed == HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "USB_PORT_FEAT_SUSPEND req not "
- "supported for USB 3.0 roothub\n");
+ "USB_PORT_FEAT_SUSPEND req not supported for USB 3.0 roothub\n");
goto error;
}
if (dum_hcd->active) {
@@ -2298,8 +2293,7 @@ static int dummy_hub_control(
/* Applicable only for USB3.0 hub */
if (hcd->speed != HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "USB_PORT_FEAT_BH_PORT_RESET req not "
- "supported for USB 2.0 roothub\n");
+ "USB_PORT_FEAT_BH_PORT_RESET req not supported for USB 2.0 roothub\n");
goto error;
}
fallthrough;
@@ -2347,8 +2341,7 @@ static int dummy_hub_control(
case GetPortErrorCount:
if (hcd->speed != HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "GetPortErrorCount req not "
- "supported for USB 2.0 roothub\n");
+ "GetPortErrorCount req not supported for USB 2.0 roothub\n");
goto error;
}
/* We'll always return 0 since this is a dummy hub */
@@ -2357,8 +2350,7 @@ static int dummy_hub_control(
case SetHubDepth:
if (hcd->speed != HCD_USB3) {
dev_dbg(dummy_dev(dum_hcd),
- "SetHubDepth req not supported for "
- "USB 2.0 roothub\n");
+ "SetHubDepth req not supported for USB 2.0 roothub\n");
goto error;
}
break;
@@ -2601,8 +2593,7 @@ static int dummy_alloc_streams(struct usb_hcd *hcd, struct usb_device *udev,
goto out;
}
if (max_stream < ret_streams) {
- dev_dbg(dummy_dev(dum_hcd), "Ep 0x%x only supports %u "
- "stream IDs.\n",
+ dev_dbg(dummy_dev(dum_hcd), "Ep 0x%x only supports %u stream IDs.\n",
eps[i]->desc.bEndpointAddress,
max_stream);
ret_streams = max_stream;
--
2.43.0
next prev parent reply other threads:[~2025-11-19 13:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:08 [PATCH 0/8] usb: gadget: dummy_hcd: coding style improvements and error handling change Clint George
2025-11-19 13:08 ` [PATCH 1/8] usb: gadget: dummy_hcd: replace BUG() with WARN_ON_ONCE() Clint George
2025-11-19 15:27 ` Greg KH
2025-11-19 13:08 ` [PATCH 2/8] usb: gadget: dummy_hcd: replace symbolic permissions (S_IRUGO) with octal (0444) Clint George
2025-11-19 13:08 ` [PATCH 3/8] usb: gadget: dummy_hcd: use 'unsigned int' instead of bare 'unsigned' Clint George
2025-11-19 13:08 ` [PATCH 4/8] usb: gadget: dummy_hcd: fix block comments, blank lines and function braces Clint George
2025-11-19 15:29 ` Greg KH
2025-11-19 15:36 ` Alan Stern
2025-11-19 13:08 ` Clint George [this message]
2025-11-19 13:08 ` [PATCH 6/8] usb: gadget: dummy_hcd: use sizeof(*ptr) instead of sizeof *ptr Clint George
2025-11-19 13:08 ` [PATCH 7/8] usb: gadget: dummy_hcd: remove unnecessary 'else' after return Clint George
2025-11-19 15:25 ` Greg KH
2025-11-19 13:08 ` [PATCH 8/8] usb: gadget: dummy_hcd: fix miscellaneous coding style warnings Clint George
2025-11-27 20:35 ` [PATCH 0/8] usb: gadget: dummy_hcd: coding style improvements and error handling change David Hunter
2025-12-01 20:37 ` [PATCH v2 0/6] usb: gadget: dummy_hcd: coding style improvements Clint George
2025-12-01 20:37 ` [PATCH v2 1/6] usb: gadget: dummy_hcd: replace symbolic permissions (S_IRUGO) with octal (0444) Clint George
2025-12-01 20:37 ` [PATCH v2 2/6] usb: gadget: dummy_hcd: use 'unsigned int' instead of bare 'unsigned' Clint George
2025-12-02 5:29 ` Greg KH
2025-12-01 20:37 ` [PATCH v2 3/6] usb: gadget: dummy_hcd: document ISO endpoint allocation pattern Clint George
2025-12-01 20:37 ` [PATCH v2 4/6] usb: gadget: dummy_hcd: use sizeof(*ptr) instead of sizeof *ptr Clint George
2025-12-01 20:37 ` [PATCH v2 5/6] usb: gadget: dummy_hcd: remove unnecessary parentheses Clint George
2025-12-01 20:37 ` [PATCH v2 6/6] usb: gadget: dummy_hcd: move function braces Clint George
2025-12-02 5:27 ` [PATCH v2 0/6] usb: gadget: dummy_hcd: coding style improvements Greg KH
2025-12-02 15:53 ` Alan Stern
2025-12-02 16:28 ` Robert P. J. Day
2025-12-04 1:01 ` David Hunter
2025-12-04 0:52 ` David Hunter
2025-12-04 0:43 ` David Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119130840.14309-6-clintbgeorge@gmail.com \
--to=clintbgeorge@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khalid@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox