From: Clint George <clintbgeorge@gmail.com>
To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
david.hunter.linux@gmail.com,
linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org,
khalid@kernel.org, Clint George <clintbgeorge@gmail.com>
Subject: [PATCH 8/8] usb: gadget: dummy_hcd: fix miscellaneous coding style warnings
Date: Wed, 19 Nov 2025 18:38:40 +0530 [thread overview]
Message-ID: <20251119130840.14309-9-clintbgeorge@gmail.com> (raw)
In-Reply-To: <20251119130840.14309-1-clintbgeorge@gmail.com>
This patch addresses several minor coding style warnings in dummy_hcd.c:
- Avoid multiple line dereference (e.g, ep0->maxpacket)
- Remove unnecessary parentheses
- Remove unnecessary line continuations (\)
Signed-off-by: Clint George <clintbgeorge@gmail.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 33 +++++++++++++++---------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index 1114dfe61..5b791ce2e 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -1423,7 +1423,7 @@ static int transfer(struct dummy_hcd *dum_hcd, struct urb *urb,
int rescan = 0;
if (dummy_ep_stream_en(dum_hcd, urb)) {
- if ((urb->stream_id != req->req.stream_id))
+ if (urb->stream_id != req->req.stream_id)
continue;
}
@@ -2222,8 +2222,7 @@ static int dummy_hub_control(
USB_PORT_STAT_HIGH_SPEED;
break;
case USB_SPEED_LOW:
- dum_hcd->dum->gadget.ep0->
- maxpacket = 8;
+ dum_hcd->dum->gadget.ep0->maxpacket = 8;
dum_hcd->port_status |=
USB_PORT_STAT_LOW_SPEED;
break;
@@ -2434,20 +2433,20 @@ static inline ssize_t show_urb(char *buf, size_t size, struct urb *urb)
break;
} s; }),
ep, ep ? (usb_urb_dir_in(urb) ? "in" : "out") : "",
- ({ char *s; \
- switch (usb_pipetype(urb->pipe)) { \
- case PIPE_CONTROL: \
- s = ""; \
- break; \
- case PIPE_BULK: \
- s = "-bulk"; \
- break; \
- case PIPE_INTERRUPT: \
- s = "-int"; \
- break; \
- default: \
- s = "-iso"; \
- break; \
+ ({ char *s;
+ switch (usb_pipetype(urb->pipe)) {
+ case PIPE_CONTROL:
+ s = "";
+ break;
+ case PIPE_BULK:
+ s = "-bulk";
+ break;
+ case PIPE_INTERRUPT:
+ s = "-int";
+ break;
+ default:
+ s = "-iso";
+ break;
} s; }),
urb->actual_length, urb->transfer_buffer_length);
}
--
2.43.0
next prev parent reply other threads:[~2025-11-19 13:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 13:08 [PATCH 0/8] usb: gadget: dummy_hcd: coding style improvements and error handling change Clint George
2025-11-19 13:08 ` [PATCH 1/8] usb: gadget: dummy_hcd: replace BUG() with WARN_ON_ONCE() Clint George
2025-11-19 15:27 ` Greg KH
2025-11-19 13:08 ` [PATCH 2/8] usb: gadget: dummy_hcd: replace symbolic permissions (S_IRUGO) with octal (0444) Clint George
2025-11-19 13:08 ` [PATCH 3/8] usb: gadget: dummy_hcd: use 'unsigned int' instead of bare 'unsigned' Clint George
2025-11-19 13:08 ` [PATCH 4/8] usb: gadget: dummy_hcd: fix block comments, blank lines and function braces Clint George
2025-11-19 15:29 ` Greg KH
2025-11-19 15:36 ` Alan Stern
2025-11-19 13:08 ` [PATCH 5/8] usb: gadget: dummy_hcd: merge multi-line quoted strings into one line Clint George
2025-11-19 13:08 ` [PATCH 6/8] usb: gadget: dummy_hcd: use sizeof(*ptr) instead of sizeof *ptr Clint George
2025-11-19 13:08 ` [PATCH 7/8] usb: gadget: dummy_hcd: remove unnecessary 'else' after return Clint George
2025-11-19 15:25 ` Greg KH
2025-11-19 13:08 ` Clint George [this message]
2025-11-27 20:35 ` [PATCH 0/8] usb: gadget: dummy_hcd: coding style improvements and error handling change David Hunter
2025-12-01 20:37 ` [PATCH v2 0/6] usb: gadget: dummy_hcd: coding style improvements Clint George
2025-12-01 20:37 ` [PATCH v2 1/6] usb: gadget: dummy_hcd: replace symbolic permissions (S_IRUGO) with octal (0444) Clint George
2025-12-01 20:37 ` [PATCH v2 2/6] usb: gadget: dummy_hcd: use 'unsigned int' instead of bare 'unsigned' Clint George
2025-12-02 5:29 ` Greg KH
2025-12-01 20:37 ` [PATCH v2 3/6] usb: gadget: dummy_hcd: document ISO endpoint allocation pattern Clint George
2025-12-01 20:37 ` [PATCH v2 4/6] usb: gadget: dummy_hcd: use sizeof(*ptr) instead of sizeof *ptr Clint George
2025-12-01 20:37 ` [PATCH v2 5/6] usb: gadget: dummy_hcd: remove unnecessary parentheses Clint George
2025-12-01 20:37 ` [PATCH v2 6/6] usb: gadget: dummy_hcd: move function braces Clint George
2025-12-02 5:27 ` [PATCH v2 0/6] usb: gadget: dummy_hcd: coding style improvements Greg KH
2025-12-02 15:53 ` Alan Stern
2025-12-02 16:28 ` Robert P. J. Day
2025-12-04 1:01 ` David Hunter
2025-12-04 0:52 ` David Hunter
2025-12-04 0:43 ` David Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119130840.14309-9-clintbgeorge@gmail.com \
--to=clintbgeorge@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=khalid@kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox