Re: [PATCH v3] mmc: pxamci: Simplify pxamci_probe() error handling using devm APIs

Rakuram Eswaran
2025-11-18T14:23:25Z

On Tue, 11 Nov 2025 at 23:06, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Thu, 23 Oct 2025 at 16:54, Rakuram Eswaran <rakuram.e96@gmail.com> wrote:
> >
> > This patch refactors pxamci_probe() to use devm-managed resource
> > allocation (e.g. devm_dma_request_chan) and dev_err_probe() for
> > improved readability and automatic cleanup on probe failure.
> >
> > It also removes redundant NULL assignments and manual resource release
> > logic from pxamci_probe(), and eliminates the corresponding release
> > calls from pxamci_remove().
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> > Closes: https://lore.kernel.org/r/202510041841.pRlunIfl-lkp@intel.com/
> > Fixes: 58c40f3faf742c ("mmc: pxamci: Use devm_mmc_alloc_host() helper")
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > Signed-off-by: Rakuram Eswaran <rakuram.e96@gmail.com>
>
> Applied for fixes, thanks!
>
> Kind regards
> Uffe
>

Hi Ulf Hansson,

Thank you for applying to fixes branch.

Hi Uwe,

Shall I start to send the patch to remove the redundant if condition
check from pxamic_remove() function?

Link to prior discussion:
https://lore.kernel.org/linux-mmc/pvid2ycmgbkbmegnnzwl4hyev6e2smusxk5olkuqxfwxzykz2e@jlvolirolrxl/

I can pull Uffe fixes branch to send the above patch? Any inputs will be
really helpful to start working on this.

Another point, I would like to ask is about the below discussion. You have
mentioned about WIP suggestion for clk_get_rate().

Link to that discussion:
https://lore.kernel.org/linux-mmc/20251020183209.11040-1-rakuram.e96@gmail.com/

Was my understanding is correct?

Best Regards,
Rakuram