From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586C1221FDE for ; Wed, 26 Nov 2025 07:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764140831; cv=none; b=PckjKPYaJ0E7eHzMFkjVQaxbTjE72Ft7Hlq4rSv+TGSORA5IkGsQeAGzBy3HQ1G6X8pwwNJNPDofX0ec0eeB4NdGTWSWxTWVsyW051P5n8MWe2t/4wny7dlWaZnSXGanToJ+lw+7bbmT8aOPHhgEMlP64hRsvC8ZFWVganaHHH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764140831; c=relaxed/simple; bh=VB4nQunFf+O3DmYPGWwxjYu5Lg4IWPHg/FOy86FFr0I=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=aHm1HchkSeHpGKgDqIZbO6gTqiTPqpMreOWBr+ct+OLT5Y7ZiT7wAO+2cPSBqzlfLns3RwEvA3pOxF1lQIymwr65J1OgAIDg7B0faWcFwWFhEmpVnVXhYu/Y2v1/BcupaB+r7YG4W3n9zO0Vvvv+8vIXhDdVS1rrXyaCyNKp8Iw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in; spf=none smtp.mailfrom=ee.vjti.ac.in; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b=O7ycKTkg; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b="O7ycKTkg" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2984dfae0acso100039035ad.0 for ; Tue, 25 Nov 2025 23:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vjti.ac.in; s=google; t=1764140830; x=1764745630; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kXm+TGMia1g3kmuDV/aF57ZmqWwNOjaNm4FLB34Qkxc=; b=O7ycKTkgnr1JGy6EXoexX7GhYen2tgD5/Y/gKpbOBdzt3L7oB5+F8Wl1nnkLH1TG4o VB4tHM3L58MEy2/7JmW1gfncBFrACoFjkjvXsamN6L9wZKDGi1WgWaCgjA+0NgaSObpX 36Z360IdL0ADAXn5lHZ9encLTF/N++fl3ipiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764140830; x=1764745630; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kXm+TGMia1g3kmuDV/aF57ZmqWwNOjaNm4FLB34Qkxc=; b=pPYsIMCJ5WH/gbS++3pobq4OFV5JqWCtehVET0rlCOE030iLYJu6SC/gMYiuwlgUWH ebHdYir1Ll5+AimGSw0I0hIoYvjDlvZiYxOWYrz54+ASzcJOrfBezE1NT28toOWlbzOV FQC6BlkxjM8k+18BUtaBYT4Vn1BsFOzBBzdBNAmgL49TS5CFgivI/ulJn02oOFiNlRsT y0LXtHsVsNbZOxnIOl6SdrRnpaqeYf8JzbI12AeM+5m97qz8BKMs5Gmau6zmlbnbbWTZ RlLzW8uBMC6IlumbAdbUchZ760M/XWcEeuB1+TeofYdaKLc5nB7OOUeZYC0rzkzWy/+R 2uFA== X-Forwarded-Encrypted: i=1; AJvYcCUD7KbQUwsQpq9fX4caKXGgz/k0XiVIhHERXkMlgxnFtuqTiyhL35dbH/SVKH9fS8aOI1IYWSvaBak8JWM1XcI87OBjKg==@lists.linux.dev X-Gm-Message-State: AOJu0YzWedI+bKWzQ2gh2t58wds1cxS9+JB/c+WZd7Ifh2jfGmvVS859 TM+OUJuyLE8wxp6Fa16PUOARC3k8TwMh2axkxbNupAz5M1W3EhHOE15Ec/ZiHXeCRDU= X-Gm-Gg: ASbGncuXOEwe4TGnLZWs2w40C1CpfqCFZRidPwqsD0u3sQjCrmIgfj8bkUDT31SQwGU PVCiPFmaaP2DcGVhcJzFlxgXdqCFBTA7KrJEIPuVCDY0aqwvBNSRFF+YVjc7HDBT35agCHBbcAB tNSxuW2fdndFweGNJjhb1ViOrXMQUOHJB/TiUhuuseT5IZptoGHE76aqpQs5sYyj1SI4fXwuGg7 9h8AVnsApaiKaCqXvz1jsbC9VIyc88ytkIiP5BH/RMdF0BBKCSbJMrivBRwcXc2TVUAH7p8S/8H SSDcfYSkGL4KIpw87pZ7cSNB0nKwZxUwe8aoKHbcw8HGU50v7w1ZwZCSDj4NZixl2uSZIhVRyQJ 6U2goJdYt2GadpBFi2IIdCtxnXH4dIEBQLbXXjrW83T59QKSUL6/OQSl+6ufA2tqrSlYLHf6uWd /KHXcoDPCsQ/cyikfpw7jOny2dWEtbXROl9FBJX7qu8K1P8kl/1mPA0ZqpqjZwlkLgfqg= X-Google-Smtp-Source: AGHT+IGkJkFFiIZ7CfI+PiIjFnbPp5NR5QiZ9xPjeb3SVz81eUnXoOljRms9fCxUpzbe+iXyOsOtgw== X-Received: by 2002:a17:902:f70c:b0:298:6a9b:238b with SMTP id d9443c01a7336-29bab1d74ddmr58569865ad.51.1764140829664; Tue, 25 Nov 2025 23:07:09 -0800 (PST) Received: from ranegod-HP-ENVY-x360-Convertible-13-bd0xxx.. ([2405:201:31:d869:7ab4:fdd5:842b:6bfe]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b105e4csm183853715ad.2.2025.11.25.23.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 23:07:09 -0800 (PST) From: ssrane_b23@ee.vjti.ac.in X-Google-Original-From: ssranevjti@gmail.com To: Oliver Hartkopp , Marc Kleine-Budde , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , Rostislav Lisovy , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shaurya Rane , syzbot+5d8269a1e099279152bc@syzkaller.appspotmail.com Subject: [PATCH v2] net/sched: em_canid: fix uninit-value in em_canid_match Date: Wed, 26 Nov 2025 12:36:41 +0530 Message-Id: <20251126070641.39532-1-ssranevjti@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shaurya Rane Use pskb_may_pull() to ensure the CAN ID is accessible in the linear data buffer before reading it. A simple skb->len check is insufficient because it only verifies the total data length but does not guarantee the data is present in skb->data (it could be in fragments). pskb_may_pull() both validates the length and pulls fragmented data into the linear buffer if necessary, making it safe to directly access skb->data. Reported-by: syzbot+5d8269a1e099279152bc@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=5d8269a1e099279152bc Fixes: f057bbb6f9ed ("net: em_canid: Ematch rule to match CAN frames according to their identifiers") Signed-off-by: Shaurya Rane --- v2: Use pskb_may_pull() instead of skb->len check to properly handle fragmented skbs (Eric Dumazet) --- net/sched/em_canid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/sched/em_canid.c b/net/sched/em_canid.c index 5337bc462755..2214b548fab8 100644 --- a/net/sched/em_canid.c +++ b/net/sched/em_canid.c @@ -99,6 +99,9 @@ static int em_canid_match(struct sk_buff *skb, struct tcf_ematch *m, int i; const struct can_filter *lp; + if (!pskb_may_pull(skb, sizeof(canid_t))) + return 0; + can_id = em_canid_get_id(skb); if (can_id & CAN_EFF_FLAG) { -- 2.34.1