From: Rakuram Eswaran <rakuram.e96@gmail.com>
To: linux-can@vger.kernel.org
Cc: mkl@pengutronix.de, socketcan@hartkopp.net, mailhol@kernel.org,
khalid@kernel.org, skhan@linuxfoundation.org,
linux-kernel@vger.kernel.org, rakuram.e96@gmail.com,
david.hunter.linux@gmail.com,
linux-kernel-mentees@lists.linux.dev
Subject: [RFC PATCH 1/2] can: dummy_can: add CAN termination support
Date: Fri, 28 Nov 2025 00:48:07 +0530 [thread overview]
Message-ID: <20251127191808.144723-2-rakuram.e96@gmail.com> (raw)
In-Reply-To: <20251127191808.144723-1-rakuram.e96@gmail.com>
Add support for configuring bus termination in the dummy_can driver.
This allows users to emulate a properly terminated CAN bus when
setting up virtual test environments.
Signed-off-by: Rakuram Eswaran <rakuram.e96@gmail.com>
---
Tested the termination setting using below iproute commands:
ip link set can0 type can termination 120
ip link set can0 type can termination off
drivers/net/can/dummy_can.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/net/can/dummy_can.c b/drivers/net/can/dummy_can.c
index 41953655e3d3..2949173547e6 100644
--- a/drivers/net/can/dummy_can.c
+++ b/drivers/net/can/dummy_can.c
@@ -23,6 +23,21 @@ struct dummy_can {
static struct dummy_can *dummy_can;
+static const u16 dummy_can_termination_const[] = {
+ CAN_TERMINATION_DISABLED, /* 0 = off */
+ 120, /* 120 Ohms */
+};
+
+static int dummy_can_set_termination(struct net_device *dev, u16 term)
+{
+ struct dummy_can *priv = netdev_priv(dev);
+
+ netdev_dbg(dev, "set termination to %u Ohms\n", term);
+ priv->can.termination = term;
+
+ return 0;
+}
+
static const struct can_bittiming_const dummy_can_bittiming_const = {
.name = "dummy_can CC",
.tseg1_min = 2,
@@ -250,6 +265,12 @@ static int __init dummy_can_init(void)
priv->can.xl.data_bittiming_const = &dummy_can_xl_databittiming_const;
priv->can.xl.tdc_const = &dummy_can_xl_tdc_const;
priv->can.xl.pwm_const = &dummy_can_pwm_const;
+
+ /* Advertise software termination support */
+ priv->can.termination_const = dummy_can_termination_const;
+ priv->can.termination_const_cnt = ARRAY_SIZE(dummy_can_termination_const);
+ priv->can.do_set_termination = dummy_can_set_termination;
+
priv->can.ctrlmode_supported = CAN_CTRLMODE_LISTENONLY |
CAN_CTRLMODE_FD | CAN_CTRLMODE_TDC_AUTO |
CAN_CTRLMODE_RESTRICTED | CAN_CTRLMODE_XL |
--
2.51.0
next prev parent reply other threads:[~2025-11-27 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 19:18 [RFC PATCH 0/2] can: add dummy_can termination and update SocketCAN docs for CAN XL Rakuram Eswaran
2025-11-27 19:18 ` Rakuram Eswaran [this message]
2025-12-23 21:33 ` [RFC PATCH 1/2] can: dummy_can: add CAN termination support Vincent Mailhol
2025-11-27 19:18 ` [RFC PATCH 2/2] docs: can: update SocketCAN documentation for CAN XL Rakuram Eswaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251127191808.144723-2-rakuram.e96@gmail.com \
--to=rakuram.e96@gmail.com \
--cc=david.hunter.linux@gmail.com \
--cc=khalid@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=skhan@linuxfoundation.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox