From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7E6F277C88 for ; Thu, 8 Jan 2026 19:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767899736; cv=none; b=ZZd7E9YQErF1Jo+9GxfP+3yhF1Crc1ixwgTbGGJnPcpMeqBcMzWVE4vySfC9F1Zj7c5p1U73Uzkl/DEUJaYxGj9u0YnQb1Hdp6MtU5NFgC9KiUlJMxOQmHIpkqNooICFX5SWd/4w3QOJBB3u3VpYysC4kDbsdZlSfZpnJstq+LY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767899736; c=relaxed/simple; bh=DQveYroOYvzQQaZj9xZbwVjXxac8T+c9fvoK8rVsEWc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=fLoFpdjstz4vJvTC5k7CWNlPlyImrgx6TOJ4DG1Tv6u772DIPJvMII+cwiBPPYgGqC+ttZhc/EbYAHEYIces+EsmEVLbUqrBfZ4fKCY3OL+13kCyU6kY27hM/0Q05ZxTfjfyxa/LkiJGoROxxpJtcX47GTMQy3+SEEwyT6ZNpQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nE4ZDSpS; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nE4ZDSpS" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7b22ffa2a88so1995269b3a.1 for ; Thu, 08 Jan 2026 11:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767899734; x=1768504534; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rbveBA5EpSAql35W21g5vkaIwp+rRmrP5kRX4QDiu4U=; b=nE4ZDSpSdaTE7lES1AaILD5PwE03x63+LoChGmqmIk2gv9OB9pLCGCffQjlBsQED0p ki1Npd8pHIf3Eyh6yjeedO8+ZFpyrH6VcXun4aQXB7C/aYP5C6fdw71Te922mePLPOoJ lDCp1Pgyxdur4QmOneT1N7ZBvner8wjrzzmD5qlFG4ckGL7HOkJlPrN/gBk2cxh0cghz urLY3QWeTYsCze+Kp6qfoYNbGcxzV+Os3521+25sAK5RZyuc2cngISRYrhGp60OGTcts p9noHhmJt1JRsFq4VzLOJy6kMYHDmgs6MUGqTY2WhvAkNzBFaeUY/ABBRm+DCGmPlXRo Iwyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767899734; x=1768504534; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rbveBA5EpSAql35W21g5vkaIwp+rRmrP5kRX4QDiu4U=; b=i+wn92eIg3gBW5Jbc4LdyKhmDk61hYSFp1jFWpvFsEaHos1G1keQ64OVgskVOon6nl EESKwgwpdN38hlx46EByKcTL76PWmvK+zeoFZRPCj+7JQAfHv35iL1CaPNMABMltuKIg xIXU3KT/GTeVYCzggJ3qWypAJLuanj7oj9AzTDAWHuD0B2+YHmh+BOhwj+m7NEfCRcs7 Osl/plcDXxEhM8fzjI15j+xBMLOvoTDdmzRjfvvHFGLQ1tC2IoiQKQxTHK3iTZEwWILj 0qHb7Pd6b1lGMUVNDatpDVu4DfF9kEwQPHccO0u/3pqOymIfcj88FXMQUcnD4Lloxax5 8oug== X-Forwarded-Encrypted: i=1; AJvYcCVEwVYE3ZX1BdjNcDR+wsjOYN6RQf4e6NWVJVIVzdYP9KsXYxLowcNbuobDusFnb05jg7Dq3N5AoRzdREu8gMx0EKamPw==@lists.linux.dev X-Gm-Message-State: AOJu0Yxu+zqMBcf2WPtAt8kw0oH4L+2dGmSGIdTSYIbjbXqZsruGnPUL ovmqgvMZMERWmlg3PiHkdf3FYn6vfF7oNTKheeSlgV2YUhdXNDGCcGrz X-Gm-Gg: AY/fxX5bfomxP8ozxbEH5lsW1K4e077NCipsnjJy8H/42ZFCgINV9MkqlRrt24lEuHp jTOI+wQHqNgsish/Vzm4a4GYPMqX8Lpt0ZIV69tjkeUBQjqGNhXC6z9gAxYJ9yK6/QxRBvmAwqH dvOtLVTHGzHFTZVfux76p+qPanpsfMi1JUWDtLA99sgngMiStvE7EAq/s34I+OFWRPi8+HTIqih +lfKK728l6jf0pPDeXh78eXHwlX4cKCpwyQdv92PlKqGSFmtAktTj12CpHCpxCI5E7n9Dtz2oM3 fTewdnlxwweqDQvRoy7twoETjEcufjVLB69kXcmF50U47TX32txpLxagEgJXN8aA9eo0eW6AxhR i9KAdDgEYH5+I1SpfWo4UzpOhS/5IMtQNGva83YvufUFadL6H0l1EVH6LIlIC0IwuF7mpSleMIq N+DJOhlx14L0U2vSrFKgdeFmggP3k= X-Google-Smtp-Source: AGHT+IE7/FzJIxSueg1FJANL4zzf06HltgWTqmNS37F5ymZQV5xCo448U9br6f7GBf0Ggq401yHQeg== X-Received: by 2002:a05:6a20:12c8:b0:366:5bda:1ebd with SMTP id adf61e73a8af0-3898f8888d4mr6519772637.2.1767899733860; Thu, 08 Jan 2026 11:15:33 -0800 (PST) Received: from localhost.localdomain ([111.125.210.92]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cc8d29521sm8616053a12.23.2026.01.08.11.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 11:15:33 -0800 (PST) From: Prithvi Tambewagh To: martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, jlbec@evilplan.org, linux-fsdevel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh , syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: [PATCH] scsi: target: Fix recursive locking in __configfs_open_file() Date: Fri, 9 Jan 2026 00:45:23 +0530 Message-Id: <20260108191523.303114-1-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In flush_write_buffer, &p->frag_sem is acquired and then the loaded store function is called, which, here, is target_core_item_dbroot_store(). This function called filp_open(), following which these functions were called (in reverse order), according to the call trace: down_read __configfs_open_file do_dentry_open vfs_open do_open path_openat do_filp_open file_open_name filp_open target_core_item_dbroot_store flush_write_buffer configfs_write_iter Hence ultimately, __configfs_open_file() was called, indirectly by target_core_item_dbroot_store(), and it also attempted to acquire &p->frag_sem, which was already held by the same thread, acquired earlier in flush_write_buffer. This poses a possibility of recursive locking, which triggers the lockdep warning. Fix this by modifying target_core_item_dbroot_store() to use kern_path() instead of filp_open() to avoid opening the file using filesystem-specific function __configfs_open_file(), and further modifying it to make this fix compatible. Reported-by: syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=f6e8174215573a84b797 Tested-by: syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com Cc: stable@vger.kernel.org Signed-off-by: Prithvi Tambewagh --- drivers/target/target_core_configfs.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index b19acd662726..f29052e6a87d 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -108,8 +108,8 @@ static ssize_t target_core_item_dbroot_store(struct config_item *item, const char *page, size_t count) { ssize_t read_bytes; - struct file *fp; ssize_t r = -EINVAL; + struct path path = {}; mutex_lock(&target_devices_lock); if (target_devices) { @@ -131,17 +131,18 @@ static ssize_t target_core_item_dbroot_store(struct config_item *item, db_root_stage[read_bytes - 1] = '\0'; /* validate new db root before accepting it */ - fp = filp_open(db_root_stage, O_RDONLY, 0); - if (IS_ERR(fp)) { + r = kern_path(db_root_stage, LOOKUP_FOLLOW, &path); + if (r) { pr_err("db_root: cannot open: %s\n", db_root_stage); goto unlock; } - if (!S_ISDIR(file_inode(fp)->i_mode)) { - filp_close(fp, NULL); + if (!d_is_dir(path.dentry)) { + path_put(&path); pr_err("db_root: not a directory: %s\n", db_root_stage); + r = -ENOTDIR; goto unlock; } - filp_close(fp, NULL); + path_put(&path); strscpy(db_root, db_root_stage); pr_debug("Target_Core_ConfigFS: db_root set to %s\n", db_root); base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 -- 2.34.1